Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow some extra labels for controller Deployment installed by the Helm chart #955

Open
sebastien-prudhomme opened this issue Oct 23, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@sebastien-prudhomme
Copy link

Is your feature request related to a problem? Please describe.

The chart doesn't allow setting extra labels on the controller Deployment or more generally doesn't allow to add some common labels to all ressources. I need it to monitor the application and set some metadata for better management of monitoring alerts.

Describe the solution you'd like

Either fix the chart to also apply "controller.extraLabels" value to the Deployment or add a new "controller.extraDeploymentLabels" value.

Same thing should be done for annotations.

Describe alternatives you've considered

Doing a "kubectl label" after applying the chart

@sebastien-prudhomme sebastien-prudhomme added the enhancement New feature or request label Oct 23, 2024
@satyamkapoor
Copy link

satyamkapoor commented Nov 4, 2024

Hi @sebastien-prudhomme, do you specifically mean that the upgrade CRD hook doesn't includes an option of deploying extraLabels?

The chart does use controller.extraDeploymentLabels for deployment but not for the crd upgrade job pod ->
helm template vso hashicorp/vault-secrets-operator --set controller.extraLabels.mylabelname=mylabelvalue | grep -A 40 "kind: Deployment"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants