Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix encoding issue in encode_path method #343

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix encoding issue in encode_path method #343

wants to merge 1 commit into from

Conversation

TaopaiC
Copy link

@TaopaiC TaopaiC commented Sep 13, 2024

Fix encode_path whitelist to exclude '-' from encoding

@TaopaiC
Fix encoding issue in encode_path method
b08f857 
Fix `encode_path` whitelist to exclude '-' from encoding
@TaopaiC TaopaiC requested a review from a team as a code owner September 13, 2024 14:23
@hashicorp-cla-app HashiCorp CLA App
Copy link

hashicorp-cla-app bot commented Sep 13, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ochnerd
Copy link

ochnerd commented Oct 1, 2024

@TaopaiC would you mind adding ':' to this commit too?
We use ':' in our secrets and have the same issue.

@khiav223577
Copy link

The current code escapes ~ as %7E, but should we be doing this? CGI.escape does not escape ~.

@khiav223577 khiav223577 mentioned this pull request Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TaopaiC @ochnerd @khiav223577