Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce dependency on pod creation for vault agent injector #1078

Open
BojanZelic opened this issue Dec 10, 2024 · 0 comments · May be fixed by #1079
Open

Reduce dependency on pod creation for vault agent injector #1078

BojanZelic opened this issue Dec 10, 2024 · 0 comments · May be fixed by #1079
Labels
enhancement New feature or request

Comments

@BojanZelic
Copy link

Is your feature request related to a problem? Please describe.
Currently if vault-agent-injector is down, we can't create any pods in the cluster even if they're not reliant on vault;

Describe the solution you'd like
Leverage matchConditions field of the MutatingWebhookConfiguration to only match the mutating webhook to pods that have the vault.hashicorp.com/agent-inject annotation

ex:

    matchConditions:
    - name: include-vault-pods
      expression: "has(object.metadata.annotations) && 'vault.hashicorp.com/agent-inject' in object.metadata.annotations"

Describe alternatives you've considered
Ignore on specific namespaces, ex kube-system but this isn't ideal because it blocks using vault-agent-injector in those namespaces

@BojanZelic BojanZelic added the enhancement New feature or request label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant