Add support for domain_OU windows customization

[ultral]

Community Guidelines

• I have read and agree to the HashiCorp Community Guidelines .
• Vote on this issue by adding a 👍 reaction to the original issue initial description to help the maintainers prioritize.
• Do not leave "+1" or other comments that do not add relevant information or questions.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Description

there is realted #996 . however after that domain_OU parameter has been released in vcenter 8.

Use Case(s)

add VM into specific during creation via single param i.e.

resource "vsphere_virtual_machine" "vm" {
  # ... other configuration ...
  clone {
    # ... other configuration ...
    customize {
      # ... other configuration ...
      windows_options {
        domain_ou             = "OU=Sandbox,OU=Workstations,DC=example,DC=com"
      }
    }
  }
}

instead kludges like

  provisioner "remote-exec" {
   inline = [
     "powershell.exe Add-Computer -DomainName 'example.com' -OUPath 'OU=Sandbox,OU=Workstations,DC=example,DC=com' -Credential (New-Object System.Management.Automation.PSCredential('example\\DomainJoin', (ConvertTo-SecureString 'mysecretpassword' -AsPlainText -Force))) -Restart -Force"
   ]
    connection {
     type     = "winrm"
     user     = "Administrator"
     password = "anothersecretpassword"
     use_ntlm = true
     host     = self.default_ip_address
    }
  }

  provisioner "remote-exec" {
   when = destroy
   inline = [
     "powershell.exe Remove-Computer -UnjoinDomaincredential (New-Object System.Management.Automation.PSCredential('example\\DomainJoin', (ConvertTo-SecureString 'mysecretpassword' -AsPlainText -Force))) -Force"
   ]
   connection {
     type     = "winrm"
     user     = "DomainJoin"
     password = "mysecretpassword"
     use_ntlm = true
     host     = self.default_ip_address 
    }
  }
} 

Potential Terraform Provider Configuration

resource "vsphere_virtual_machine" "vm" {
  # ... other configuration ...
  clone {
    # ... other configuration ...
    customize {
      # ... other configuration ...
      windows_options {
        domain_ou             = "OU=Sandbox,OU=Workstations,DC=example,DC=com"
      }
    }
  }
}

References

• Lack of support for OUPath field on AD join #996
• https://developer.vmware.com/apis/vsphere-automation/latest/vcenter/data-structures/Guest/Domain/
• https://learn.microsoft.com/en-us/windows-hardware/customize/desktop/unattend/microsoft-windows-unattendedjoin-identification-machineobjectou

[github-actions]

Hello, ultral! 🖐

Thank you for submitting an issue for this provider. The issue will now enter into the issue lifecycle.

If you want to contribute to this project, please review the contributing guidelines and information on submitting pull requests.

[tenthirtyam]

Duplicate of #2130

[github-actions]

This functionality has been released in v2.8.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.