-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add data source vgpu profiles #2048
Conversation
The markdown for the data source docs should also be included. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mristok this is a great augmentation to the provider but I think that this data should be part of the vsphere_host
data source. This will make it more consistent for the users as they will have to write less HCL code. I also do not see an acceptance test for this functionality and this will be a very good addition to the PR.
Best regards, Vasil
@vasilsatanasov This functionality can be moved into the Also, I did not add any acceptance tests to this given that the GPU based hardware in Equinix Metal is expensive (and based on 12/36 month contracts). If this were to be added to the acceptance tests would the following be in line with your vision:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This functionality has been released in v2.7.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Add a new data source to the provider to query and return available vGPU profiles for a host.
Acceptance tests
No acceptance tests added.
Provider tests
Output from provider testing:
ESXi host with A100 GPU
ESXi host with A100 GPU - no vGPU profile name filter
ESXi host with A100 GPU - vGPU profile name filter
grid_a100d-80c
ESXi host without GPU
ESXi host without GPU - no vGPU profile name filter
ESXi host without GPU - vGPU profile name filter
grid_a100d-80c
Release Note
Release note for CHANGELOG:
References
Closes #2047