Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update guide-breaking-changes.md #28222

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Docs: Update guide-breaking-changes.md #28222

merged 3 commits into from
Dec 11, 2024

Conversation

sreallymatt
Copy link
Collaborator

@sreallymatt sreallymatt commented Dec 9, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Updating breaking changes guide

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@ziyeqf
Copy link
Contributor

ziyeqf commented Dec 10, 2024

Hi @sreallymatt, mind adding a () on line 169? so that I don't need to open another PR for it. :)

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks LGTM 🌩️

@stephybun stephybun merged commit 4153c30 into main Dec 11, 2024
3 checks passed
@stephybun stephybun deleted the mp/contributor-guides branch December 11, 2024 08:09
@github-actions github-actions bot added this to the v4.14.0 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants