Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource - azurerm_linux_function_app_flex_consumption #28199

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

New Resource - azurerm_linux_function_app_flex_consumption #28199

wants to merge 5 commits into from
+3,343 −1

Conversation

xiaxyi
Copy link
Contributor

@xiaxyi xiaxyi commented Dec 6, 2024 •
edited by rcskosir
Loading

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

To make a separate pr for this new feature, referring to the #27531

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@xiaxyi xiaxyi requested a review from a team as a code owner December 6, 2024 10:11
@xiaxyi xiaxyi mentioned this pull request Dec 6, 2024
Open
14 tasks
@nzthiago
Copy link

nzthiago commented Dec 6, 2024 •
edited
Loading

@xiaxyi - thank you for this PR. Only note from me is we don't want customers to worry about operating system, with no plans for a Windows version of Flex Consumption in the foreseeable future. Can we please simplify the name and code not to have Linux in it for Flex Consumption? Other than that I'm happy with separating it out into its own resource type, thank you.

@xiaxyi
Copy link
Contributor Author

xiaxyi commented Dec 10, 2024

Thanks @nzthiago for the suggestions, @jackofallops are you agree with the idea of removing the linux part?

@nzthiago
Copy link

Following up on this one @jackofallops - from the Azure Functions PG we would prefer to drop 'linux' from the resource name.

@pcsrijith
Copy link

@jackofallops : Could you please update on @nzthiago 's suggestions? We are eagerly waiting for this actually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation enhancement new-resource service/app-service size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiaxyi @nzthiago @pcsrijith @rcskosir