Palo Alto Networks: Cloud NGFW - Support for parametrized OfferId and PlanId attributes

[abudilovskiy-panw]

Is there an existing issue for this?

• I have searched the existing issues

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment and review the contribution guide to help.

Description

Currently the attributes describing the Marketplace Offer and Plan IDs are hardcoded in Golang. Please implement a way to pass them as a TF resource argument. This configuration is required to support plan changes and private offers.

https://github.com/hashicorp/terraform-provider-azurerm/blob/main/internal/services/paloalto/next_generation_firewall_vhub_local_rulestack_resource.go#L129:

MarketplaceDetails: firewalls.MarketplaceDetails{
						OfferId:     "pan_swfw_cloud_ngfw",
						PublisherId: "paloaltonetworks",
					},
					NetworkProfile: schema.ExpandNetworkProfileVHub(model.NetworkProfile),
					PlanData: firewalls.PlanData{
						BillingCycle: firewalls.BillingCycleMONTHLY,
						PlanId:       "panw-cloud-ngfw-payg",
					},

New or Affected Resource(s)/Data Source(s)

azurerm_palo_alto_next_generation_firewall_virtual_network_local_rulestack, azurerm_palo_alto_next_generation_firewall_virtual_network_panorama, azurerm_palo_alto_next_generation_firewall_virtual_hub_local_rulestack, azurerm_palo_alto_next_generation_firewall_virtual_hub_panorama

Potential Terraform Configuration

resource "azurerm_palo_alto_next_generation_firewall_virtual_network_panorama" "example" {
  name                   = "example-ngfwvh"
  resource_group_name    = azurerm_resource_group.example.name
  location               = azurerm_resource_group.example.location
  offer_id               = "example-offer-id"
  plan_id                = "example-plan-id

<remainder ommitted>

References

No response