azurerm_cognitive_deployment dynamic quota

[guilhem]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #23988

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[stephybun]

Thanks for this PR @guilhem. I left some suggestions in-line, once those have been fixed up and the conflicts resolved we can run the tests.

[justrp]

hey @guilhem , really appreciate the work you did!
Would you have some time to address comments left here so we can start using that? if you're busy now - please share that, so I could try to cover what's left here.

[guilhem]

@justrp that should be ok

[guilhem]

terrafmt fix

[justrp]

hey @stephybun , could you please check this PR? :)

[plieberg]

Is there a status on this PR? While there are potential work-arounds, this feature is important for us.

[katbyte]

Thanks @guilhem - however it looks like we need to enable a feature to include this property in the payload? tests are fialing for us with:

------- Stdout: -------
=== RUN   TestAccCognitiveAccount_dynamicThrottlingEnabled
=== PAUSE TestAccCognitiveAccount_dynamicThrottlingEnabled
=== CONT  TestAccCognitiveAccount_dynamicThrottlingEnabled
    testcase.go:113: Step 1/6 error: Error running apply: exit status 1
        
        Error: creating Account (Subscription: "*******"
        Resource Group Name: "acctestRG-cognitive-240618210056039722"
        Account Name: "acctestcogacc-240618210056039722"): unexpected status 400 (400 Bad Request) with error: SpecialFeatureOrQuotaIdRequired: The subscription does not have QuotaId/Feature required by SKU 'S0' from kind 'LUIS' or contains blocked QuotaId/Feature.
        
          with azurerm_cognitive_account.test,
          on terraform_plugin_test.tf line 28, in resource "azurerm_cognitive_account" "test":
          28: resource "azurerm_cognitive_account" "test" {
        
--- FAIL: TestAccCognitiveAccount_dynamicThrottlingEnabled (169.38s)
FAIL

could you update the documentation on how users can enable this feature? And will adding this break the resource for users who have not enabled it?

[triforcely]

Hey, has there been any progress on that? This is quite an important piece for making cognitive deployments to Azure for us.

[plieberg]

Can we get a validation on this? The error received in the test is usually caused by using a free or student account, which no longer support Cognitive Services deployments. A pay-as-you-go subscription is required.

Also, your subscription must be approved by MS and you must be creating resources in the approved region. Often people get approved for eastus, but specify eastus2 as their region.

Lastly, I believe the S0 SKUs were retired from some Kinds and are no longer available and that is the referenced SKU in the error message.

Just trying to move this PR along.

[katbyte]

@plieberg - the subscription is not a free/student one, however if S0 has been retired it likely means this pr (and the rest of the service) tests need to be updated to pass.

Once that (and the merge conflicts are fixed) we can look at this PR again

[github-actions]

This PR is being labeled as "stale" because it has not been updated for 30 or more days.

If this PR is still valid, please remove the "stale" label. If this PR is blocked, please add it to the "Blocked" milestone.

If you need some help completing this PR, please leave a comment letting us know. Thank you!

[stephybun]

Since we haven't heard back and this PR has been marked as stale I'm going to close this for the moment. If someone is willing to pick this work up again let us know and we can reopen this, or feel free to open a fresh PR (might be better given the merge conflicts this has accumulated).

[guilhem]

@stephybun it's just the developer experience working on this providers is horrible.
I've made a lot of rebase and wait a lot of time.
When #28100 have been merged in days

[stephybun]

@guilhem I understand that the experience of opening a PR for this project is inconsistent and I apologise for the intermittent attention it has received and any frustration this has caused for you.

If you decide to contribute again in future (and we're hoping that you do!) I can provide some guidelines that you can follow to get your PRs reviewed and merged quicker. Generally speaking the more changes a PR contains the longer it will take us to review. The more review cycles a PR requires the longer it will take us to keep coming back to it

This PR

• Updates the go-azure-sdk which we always recommend be done in a separate PR since it gets updated often and then causes merge conflicts requiring a rebase, as has happened here
• Updates the API version of a service. We tread carefully when updating a service that was previously using a stable version to using a preview since it's more likely that this can introduce breaking changes further down the line
• Adds the new property

In our guidelines for opening a PR we would recommend splitting this into 3 PRs, which is how #28100 made it in so quickly.

[guilhem]

@stephybun thanks ;)