Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top-level attributes that conflict with Terraform meta arguments #140

Closed
ewbankkit opened this issue Sep 8, 2021 · 3 comments · Fixed by #1503
Closed

Top-level attributes that conflict with Terraform meta arguments #140

ewbankkit opened this issue Sep 8, 2021 · 3 comments · Fixed by #1503
Labels
code-generation Relates to the conversion of CloudFormation schema to Terraform schema at buildtime. schema-handling Relates to retrieval and handling of CloudFormation schema at buildtime. upstream-aws Unable to proceed due to missing or broken functionality from an AWS dependency.

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented Sep 8, 2021

Terraform has a handful of meta-arguments such as provider that can conflict with top-level properties defined in CloudFormation schemas.
In fact the awscc_networkmanager_link resource has such a conflicting provider attribute.

  1. Verify with Terraform Core that such a conflict exists
  2. Determine how many resources are affected
  3. Come up with a plan on how to handle these

Relates:

@ewbankkit ewbankkit added code-generation Relates to the conversion of CloudFormation schema to Terraform schema at buildtime. schema-handling Relates to retrieval and handling of CloudFormation schema at buildtime. labels Sep 8, 2021
@ewbankkit
Copy link
Contributor Author

awscc_networkmanager_link is the only resource that this applies to.
For now, suppress generation.

@ewbankkit
Copy link
Contributor Author

In hashicorp/terraform-provider-aws#13251 the corresponding attribute is named provider_name.

@ewbankkit
Copy link
Contributor Author

ewbankkit commented Apr 2, 2024

There are 4 resources with a top-level Provider property:

  • awscc_codepipeline_custom_action_type
  • awscc_datazone_environment
  • awscc_datazone_subscription_target
  • awscc_networkmanager_link

The aws_codepipeline_custom_action_type and aws_networkmanager_link resources name this attribute provider_name. There are not yet any corresponding DataZone resources in terraform-provider-aws.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-generation Relates to the conversion of CloudFormation schema to Terraform schema at buildtime. schema-handling Relates to retrieval and handling of CloudFormation schema at buildtime. upstream-aws Unable to proceed due to missing or broken functionality from an AWS dependency.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants