From 3423f31615672c85dea3f4332799b02275f18914 Mon Sep 17 00:00:00 2001
From: Jeff Daley <jeffdaley@users.noreply.github.com>
Date: Fri, 27 Oct 2023 09:39:22 -0400
Subject: [PATCH] Add `JiraObject` type (#386)

* Update project.d.ts

* Update property name

* Fix failing tests

* Change JiraObject `type` definition
---
 web/app/components/project/tile.hbs           |  8 +++----
 web/app/components/project/tile.ts            |  2 +-
 web/app/types/project.d.ts                    | 24 ++++++++++---------
 .../acceptance/authenticated/projects-test.ts |  8 +++----
 .../components/project/tile-test.ts           |  8 +++----
 5 files changed, 24 insertions(+), 26 deletions(-)

diff --git a/web/app/components/project/tile.hbs b/web/app/components/project/tile.hbs
index 464f441fd..db091684b 100644
--- a/web/app/components/project/tile.hbs
+++ b/web/app/components/project/tile.hbs
@@ -35,11 +35,9 @@
       {{/if}}
       {{#if this.jiraObject}}
         <div class="flex items-center gap-1.5">
-          {{#if @project.jiraObject.type}}
-            <span data-test-jira-type>
-              {{@project.jiraObject.type}}
-            </span>
-          {{/if}}
+          <span data-test-jira-type>
+            {{@project.jiraObject.type}}
+          </span>
           <span
             data-test-jira-key
             class="text-body-100 text-color-foreground-faint
diff --git a/web/app/components/project/tile.ts b/web/app/components/project/tile.ts
index 369a8ade9..22cc43990 100644
--- a/web/app/components/project/tile.ts
+++ b/web/app/components/project/tile.ts
@@ -10,7 +10,7 @@ interface ProjectTileComponentSignature {
 
 export default class ProjectTileComponent extends Component<ProjectTileComponentSignature> {
   protected get documents() {
-    return this.args.project.documents;
+    return this.args.project.hermesDocuments;
   }
 
   protected get jiraObject() {
diff --git a/web/app/types/project.d.ts b/web/app/types/project.d.ts
index 4336c9636..d7021439c 100644
--- a/web/app/types/project.d.ts
+++ b/web/app/types/project.d.ts
@@ -4,22 +4,24 @@ import {
 } from "hermes/components/related-resources";
 import { ProjectStatus } from "./project-status";
 
+export interface JiraObject {
+  key: string;
+  url: string;
+  priority: string;
+  status: string;
+  assignee?: string;
+  type: string;
+  summary: string;
+}
+
 export interface HermesProject {
   id: string; // at least in Mirage...
   title: string;
   status: ProjectStatus;
-  documents?: RelatedHermesDocument[];
+  hermesDocuments?: RelatedHermesDocument[];
   description?: string;
-  jiraObject?: {
-    key: string;
-    url: string;
-    priority: string;
-    status: string;
-    assignee?: string;
-    type?: string;
-    summary: string;
-  };
-  relatedLinks?: RelatedExternalLink[];
+  jiraObject?: JiraObject;
+  externalLinks?: RelatedExternalLink[];
   creator: string; // maybe a Google/HermesUser
   dateCreated: number;
   dateModified: number;
diff --git a/web/tests/acceptance/authenticated/projects-test.ts b/web/tests/acceptance/authenticated/projects-test.ts
index cb63bceb4..d596fc896 100644
--- a/web/tests/acceptance/authenticated/projects-test.ts
+++ b/web/tests/acceptance/authenticated/projects-test.ts
@@ -51,12 +51,10 @@ module("Acceptance | authenticated/projects", function (hooks) {
 
         if (project.jiraObject) {
           expectedKeys.push(project.jiraObject.key);
-          if (project.jiraObject.type) {
-            expectedJiraTypes.push(project.jiraObject.type);
-          }
+          expectedJiraTypes.push(project.jiraObject.type);
         }
-        if (project.documents) {
-          project.documents.forEach((doc) => {
+        if (project.hermesDocuments) {
+          project.hermesDocuments.forEach((doc) => {
             if (doc.product) {
               expectedProducts.push(doc.product);
             }
diff --git a/web/tests/integration/components/project/tile-test.ts b/web/tests/integration/components/project/tile-test.ts
index 0d5249aac..eec331484 100644
--- a/web/tests/integration/components/project/tile-test.ts
+++ b/web/tests/integration/components/project/tile-test.ts
@@ -26,7 +26,7 @@ module("Integration | Component | project/tile", function (hooks) {
     this.project = this.server.create("project", {
       title: "Test Title",
       description: "Test Description",
-      documents: [
+      hermesDocuments: [
         {
           product: "Foo",
         },
@@ -46,8 +46,8 @@ module("Integration | Component | project/tile", function (hooks) {
       <Project::Tile @project={{this.project}} />
     `);
 
-    const { title, description, documents, jiraObject } = this.project;
-    const documentProducts = documents
+    const { title, description, hermesDocuments, jiraObject } = this.project;
+    const documentProducts = hermesDocuments
       ?.map((doc) => doc.product as string)
       .uniq();
 
@@ -77,7 +77,7 @@ module("Integration | Component | project/tile", function (hooks) {
 
     project.update({
       description: null,
-      documents: null,
+      hermesDocuments: null,
       jiraObject: null,
     });