From 1637b68d16b7e23c267d73d468b8a48243370d40 Mon Sep 17 00:00:00 2001 From: Jeff Daley Date: Wed, 6 Sep 2023 10:33:06 -0400 Subject: [PATCH 1/7] Remove console.logs --- web/app/routes/authenticated/document.ts | 6 ------ 1 file changed, 6 deletions(-) diff --git a/web/app/routes/authenticated/document.ts b/web/app/routes/authenticated/document.ts index eb8ea0dc8..a7771e65d 100644 --- a/web/app/routes/authenticated/document.ts +++ b/web/app/routes/authenticated/document.ts @@ -63,7 +63,6 @@ export default class DocumentRoute extends Route { let doc = {}; let draftFetched = false; - console.log("params.draft", params.draft); // Get doc data from the app backend. if (params.draft) { try { @@ -106,7 +105,6 @@ export default class DocumentRoute extends Route { .then((r) => r?.json()); (doc as HermesDocument).isDraft = false; - console.log("isDraft?", (doc as HermesDocument).isDraft); } catch (err) { const typedError = err as Error; this.showErrorMessage(typedError); @@ -121,8 +119,6 @@ export default class DocumentRoute extends Route { // make a background call to update the front-end index. void this.recentDocs.fetchAll.perform(); - console.log("Document fetched: ", doc); - let typedDoc = doc as HermesDocument; // Record analytics. @@ -165,8 +161,6 @@ export default class DocumentRoute extends Route { } } - console.log("typedDoc", typedDoc); - let docTypes = await this.fetchSvc .fetch("/api/v1/document-types") .then((r) => r?.json()); From adb2db109b85a28a1401dcaf967f7063c654e005 Mon Sep 17 00:00:00 2001 From: Jeff Daley Date: Wed, 6 Sep 2023 10:35:02 -0400 Subject: [PATCH 2/7] Update document.ts --- web/app/routes/authenticated/document.ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/web/app/routes/authenticated/document.ts b/web/app/routes/authenticated/document.ts index a7771e65d..8ef126942 100644 --- a/web/app/routes/authenticated/document.ts +++ b/web/app/routes/authenticated/document.ts @@ -28,6 +28,11 @@ interface DocumentRouteParams { draft: boolean; } +interface DocumentRouteModel { + doc: HermesDocument; + docType: HermesDocumentType; +} + export default class DocumentRoute extends Route { @service("config") declare configSvcL: ConfigService; @service("fetch") declare fetchSvc: FetchService; @@ -182,7 +187,7 @@ export default class DocumentRoute extends Route { * `modelIsChanging` property to remove and rerender the sidebar, * resetting its local state to reflect the new model data. */ - afterModel(model: any, transition: any) { + afterModel(_model: DocumentRouteModel, transition: any) { if (transition.from) { if (transition.from.name === transition.to.name) { if ( From ed43ee74762a321bfa08a7588392d8d76a323ace Mon Sep 17 00:00:00 2001 From: Jeff Daley Date: Mon, 11 Sep 2023 10:58:49 -0400 Subject: [PATCH 3/7] Improve loading states --- web/app/components/custom-editable-field.hbs | 4 +- web/app/components/custom-editable-field.ts | 2 +- web/app/components/document/index.hbs | 10 +- web/app/components/document/index.ts | 16 +++- web/app/components/document/sidebar.hbs | 22 +++-- web/app/components/document/sidebar.ts | 63 ++++++++++++- .../components/document/sidebar/header.hbs | 2 +- web/app/components/document/sidebar/header.ts | 1 + web/app/components/editable-field.hbs | 26 +++-- web/app/components/editable-field.ts | 7 +- .../inputs/product-select/index.hbs | 4 +- web/app/routes/authenticated/document.ts | 94 +++---------------- web/app/styles/components/editable-field.scss | 6 -- web/app/templates/authenticated/document.hbs | 8 +- .../components/editable-field-test.ts | 2 +- 15 files changed, 140 insertions(+), 127 deletions(-) diff --git a/web/app/components/custom-editable-field.hbs b/web/app/components/custom-editable-field.hbs index be7c5f777..914d62e69 100644 --- a/web/app/components/custom-editable-field.hbs +++ b/web/app/components/custom-editable-field.hbs @@ -3,7 +3,7 @@ data-test-custom-string-field @value={{get @document @field}} @onChange={{@onChange}} - @loading={{@loading}} + @isSaving={{@isSaving}} @disabled={{@disabled}} > <:default as |F|> @@ -31,7 +31,7 @@ data-test-custom-people-field @value={{get @attributes "value"}} @onChange={{@onChange}} - @loading={{@loading}} + @isSaving={{@isSaving}} @disabled={{@disabled}} > <:default> diff --git a/web/app/components/custom-editable-field.ts b/web/app/components/custom-editable-field.ts index 1d7e9fc79..83d0e4412 100644 --- a/web/app/components/custom-editable-field.ts +++ b/web/app/components/custom-editable-field.ts @@ -13,7 +13,7 @@ interface CustomEditableFieldComponentSignature { field: string; attributes: CustomEditableField; onChange: (value: any) => void; - loading?: boolean; + isSaving?: boolean; disabled?: boolean; }; } diff --git a/web/app/components/document/index.hbs b/web/app/components/document/index.hbs index 9a63b6b88..65e4008a0 100644 --- a/web/app/components/document/index.hbs +++ b/web/app/components/document/index.hbs @@ -1,4 +1,7 @@ -
+
@@ -11,19 +14,18 @@ @profile={{this.authenticatedUser.info}} @document={{@document}} @deleteDraft={{perform this.deleteDraft}} - @docType={{@docType}} @isCollapsed={{this.sidebarIsCollapsed}} @toggleCollapsed={{this.toggleSidebarCollapsedState}} /> {{/unless}}
-
+
{{#unless @modelIsChanging}} {{! diff --git a/web/app/components/document/index.ts b/web/app/components/document/index.ts index 0095d517d..09301b0e9 100644 --- a/web/app/components/document/index.ts +++ b/web/app/components/document/index.ts @@ -12,7 +12,6 @@ import { action } from "@ember/object"; interface DocumentIndexComponentSignature { document: HermesDocument; - docType: string; modelIsChanging: boolean; } @@ -30,6 +29,21 @@ export default class DocumentIndexComponent extends Component { try { let fetchResponse = await this.fetchSvc.fetch("/api/v1/drafts/" + docID, { diff --git a/web/app/components/document/sidebar.hbs b/web/app/components/document/sidebar.hbs index 4a78708b4..7a1456106 100644 --- a/web/app/components/document/sidebar.hbs +++ b/web/app/components/document/sidebar.hbs @@ -1,4 +1,5 @@ @@ -146,7 +147,7 @@ data-test-editable={{this.isOwner}} @value={{this.summary}} @onChange={{perform this.updateSummary}} - @loading={{this.save.isRunning}} + @isSaving={{this.save.isRunning}} @disabled={{not this.isOwner}} > <:default as |F|> @@ -213,7 +214,8 @@ data-test-editable={{this.isOwner}} @value={{this.contributors}} @onChange={{perform this.save "contributors"}} - @loading={{this.save.isRunning}} + @isLoading={{this.serializeContributorsAndApprovers.isRunning}} + @isSaving={{this.save.isRunning}} @disabled={{not this.isOwner}} > <:default> @@ -251,7 +253,8 @@ data-test-editable={{this.isOwner}} @value={{this.approvers}} @onChange={{perform this.save "approvers"}} - @loading={{this.save.isRunning}} + @isLoading={{this.serializeContributorsAndApprovers.isRunning}} + @isSaving={{this.save.isRunning}} @disabled={{this.editingIsDisabled}} > <:default> @@ -321,7 +324,7 @@ @field={{field}} @attributes={{attributes}} @onChange={{perform this.save field}} - @loading={{this.save.isRunning}} + @isSaving={{this.save.isRunning}} @disabled={{not this.isOwner}} />
@@ -378,7 +381,7 @@ @size="medium" @color="primary" class="w-full" - {{on "click" (fn (set this "requestReviewModalIsShown" true))}} + {{on "click" (set this "requestReviewModalIsShown" true)}} /> <:default as |M|> {{#if M.taskIsRunning}} @@ -575,9 +579,9 @@ Approvers - {{#if @docType.checks.length}} + {{#if this.docType.checks}} {{! For now, we only support one check }} - {{#each (take 1 @docType.checks) as |check|}} + {{#each (take 1 this.docType.checks) as |check|}}
{ + return people.map((p) => ({ + email: p.emailAddresses[0]?.value as string, + imgURL: p.photos?.[0]?.url, + })); +}; + interface DocumentSidebarComponentSignature { Args: { profile: AuthenticatedUser; document: HermesDocument; - docType: HermesDocumentType; deleteDraft: (docId: string) => void; isCollapsed: boolean; toggleCollapsed: () => void; @@ -69,6 +76,8 @@ export default class DocumentSidebarComponent extends Component { + const docTypes = (await this.fetchSvc + .fetch("/api/v1/document-types") + .then((r) => r?.json())) as HermesDocumentType[]; + + assert("docTypes must exist", docTypes); + + const docType = docTypes.find( + (dt) => dt.name === this.args.document.docType + ); + + assert("docType must exist", docType); + this.docType = docType; + }); + @action refreshRoute() { // We force refresh due to a bug with `refreshModel: true` // See: https://github.com/emberjs/ember.js/issues/19260 @@ -506,6 +530,43 @@ export default class DocumentSidebarComponent extends Component { + let maybePromises = []; + + const contributorsPromise = this.fetchSvc + .fetch(`/api/v1/people?emails=${this.contributors.join(",")}`) + .then((r) => r?.json()); + + const approversPromise = this.fetchSvc + .fetch(`/api/v1/people?emails=${this.approvers.join(",")}`) + .then((r) => r?.json()); + + maybePromises.push(this.contributors.length ? contributorsPromise : []); + maybePromises.push(this.approvers.length ? approversPromise : []); + + if (!maybePromises.length) { + return; + } + + const [contributors, approvers] = await Promise.all(maybePromises); + + console.log("contributors", contributors); + console.log("approvers", approvers); + + if (contributors.length) { + this.contributors = serializePeople(contributors); + } + + if (approvers.length) { + this.approvers = serializePeople(approvers); + } + }); + /** * A task that waits for a short time and then resolves. * Used to trigger the "link created" state of the share button. diff --git a/web/app/components/document/sidebar/header.hbs b/web/app/components/document/sidebar/header.hbs index 38095958c..03f11338c 100644 --- a/web/app/components/document/sidebar/header.hbs +++ b/web/app/components/document/sidebar/header.hbs @@ -1,4 +1,4 @@ -
+
- {{#if (and this.editingIsEnabled (not @loading))}} + {{#if this.editingBlockIsShown}} {{on-document "keydown" this.handleKeydown}} {{yield (hash @@ -11,15 +11,21 @@ to="editing" }} {{else}} - {{#if @loading}} - + {{#if (or @isSaving @isLoading)}} +
+ +
{{/if}} - - {{yield (hash value=this.value)}} - + {{#unless @isLoading}} + + {{yield (hash value=this.value)}} + + {{/unless}} {{/if}}
diff --git a/web/app/components/editable-field.ts b/web/app/components/editable-field.ts index 6d3affcd2..220a52424 100644 --- a/web/app/components/editable-field.ts +++ b/web/app/components/editable-field.ts @@ -14,7 +14,8 @@ interface EditableFieldComponentSignature { Args: { value: any; onChange: (value: any) => void; - loading?: boolean; + isLoading?: boolean; + isSaving?: boolean; disabled?: boolean; isRequired?: boolean; }; @@ -77,6 +78,10 @@ export default class EditableFieldComponent extends Component {{/if}} {{else if this.fetchProductAreas.isRunning}} - +
+ +
{{else if this.errorIsShown}}
Failed to load diff --git a/web/app/routes/authenticated/document.ts b/web/app/routes/authenticated/document.ts index 8ef126942..7b5b700df 100644 --- a/web/app/routes/authenticated/document.ts +++ b/web/app/routes/authenticated/document.ts @@ -1,45 +1,27 @@ import Route from "@ember/routing/route"; import { inject as service } from "@ember/service"; -import RSVP from "rsvp"; import htmlElement from "hermes/utils/html-element"; import { schedule } from "@ember/runloop"; -import { GoogleUser } from "hermes/components/inputs/people-select"; -import ConfigService from "hermes/services/config"; import FetchService from "hermes/services/fetch"; -import RecentlyViewedDocsService from "hermes/services/recently-viewed-docs"; -import AlgoliaService from "hermes/services/algolia"; -import SessionService from "hermes/services/session"; import FlashMessageService from "ember-cli-flash/services/flash-messages"; import RouterService from "@ember/routing/router-service"; -import { HermesDocument, HermesUser } from "hermes/types/document"; +import { HermesDocument } from "hermes/types/document"; import Transition from "@ember/routing/transition"; import { HermesDocumentType } from "hermes/types/document-type"; import AuthenticatedDocumentController from "hermes/controllers/authenticated/document"; -const serializePeople = (people: GoogleUser[]): HermesUser[] => { - return people.map((p) => ({ - email: p.emailAddresses[0]?.value as string, - imgURL: p.photos?.[0]?.url, - })); -}; - -interface DocumentRouteParams { +interface AuthenticatedDocumentRouteParams { document_id: string; draft: boolean; } -interface DocumentRouteModel { +interface AuthenticatedDocumentRouteModel { doc: HermesDocument; docType: HermesDocumentType; } -export default class DocumentRoute extends Route { - @service("config") declare configSvcL: ConfigService; +export default class AuthenticatedDocumentRoute extends Route { @service("fetch") declare fetchSvc: FetchService; - @service("recently-viewed-docs") - declare recentDocs: RecentlyViewedDocsService; - @service declare algolia: AlgoliaService; - @service declare session: SessionService; @service declare flashMessages: FlashMessageService; @service declare router: RouterService; @@ -64,7 +46,10 @@ export default class DocumentRoute extends Route { }); } - async model(params: DocumentRouteParams, transition: Transition) { + async model( + params: AuthenticatedDocumentRouteParams, + transition: Transition + ) { let doc = {}; let draftFetched = false; @@ -92,11 +77,11 @@ export default class DocumentRoute extends Route { */ transition.abort(); this.router.transitionTo("authenticated.document", params.document_id); - return; } } if (!draftFetched) { + console.log("fetching doc"); try { doc = await this.fetchSvc .fetch("/api/v1/documents/" + params.document_id, { @@ -120,64 +105,7 @@ export default class DocumentRoute extends Route { } } - // With the document fetched and added to the db's RecentlyViewedDocs index, - // make a background call to update the front-end index. - void this.recentDocs.fetchAll.perform(); - - let typedDoc = doc as HermesDocument; - - // Record analytics. - try { - await this.fetchSvc.fetch("/api/v1/web/analytics", { - method: "POST", - headers: { "Content-Type": "application/json" }, - body: JSON.stringify({ - document_id: params.document_id, - product_name: typedDoc.product, - }), - }); - } catch (err) { - console.log("Error recording analytics: " + err); - } - - // Load the document as well as the logged in user info - - // Preload avatars for all approvers in the Algolia index. - if (typedDoc.contributors?.length) { - const contributors = await this.fetchSvc - .fetch(`/api/v1/people?emails=${typedDoc.contributors.join(",")}`) - .then((r) => r?.json()); - - if (contributors) { - typedDoc.contributors = serializePeople(contributors); - } else { - typedDoc.contributors = []; - } - } - if (typedDoc.approvers?.length) { - const approvers = await this.fetchSvc - .fetch(`/api/v1/people?emails=${typedDoc.approvers.join(",")}`) - .then((r) => r?.json()); - - if (approvers) { - typedDoc.approvers = serializePeople(approvers); - } else { - typedDoc.approvers = []; - } - } - - let docTypes = await this.fetchSvc - .fetch("/api/v1/document-types") - .then((r) => r?.json()); - - let docType = docTypes.find( - (docType: HermesDocumentType) => docType.name === typedDoc.docType - ); - - return RSVP.hash({ - doc: typedDoc, - docType, - }); + return doc as HermesDocument; } /** @@ -187,7 +115,7 @@ export default class DocumentRoute extends Route { * `modelIsChanging` property to remove and rerender the sidebar, * resetting its local state to reflect the new model data. */ - afterModel(_model: DocumentRouteModel, transition: any) { + afterModel(_model: AuthenticatedDocumentRouteModel, transition: any) { if (transition.from) { if (transition.from.name === transition.to.name) { if ( diff --git a/web/app/styles/components/editable-field.scss b/web/app/styles/components/editable-field.scss index d36de92a5..b0ca24e0c 100644 --- a/web/app/styles/components/editable-field.scss +++ b/web/app/styles/components/editable-field.scss @@ -52,10 +52,4 @@ } } } - - .loading-indicator { - position: absolute; - top: 0; - right: 0; - } } diff --git a/web/app/templates/authenticated/document.hbs b/web/app/templates/authenticated/document.hbs index 42333299e..588b7b811 100644 --- a/web/app/templates/authenticated/document.hbs +++ b/web/app/templates/authenticated/document.hbs @@ -1,8 +1,4 @@ -{{page-title (or @model.doc.title "Document")}} +{{page-title (or @model.title "Document")}} {{set-body-class "secondary-screen"}} - + diff --git a/web/tests/integration/components/editable-field-test.ts b/web/tests/integration/components/editable-field-test.ts index 3c3f2f16f..9b57116c0 100644 --- a/web/tests/integration/components/editable-field-test.ts +++ b/web/tests/integration/components/editable-field-test.ts @@ -84,7 +84,7 @@ module("Integration | Component | editable-field", function (hooks) { `); From 04b563cc0053eeee741487222b13ff0b1a26cb57 Mon Sep 17 00:00:00 2001 From: Jeff Daley Date: Mon, 11 Sep 2023 11:05:07 -0400 Subject: [PATCH 4/7] Update/add tests --- web/app/components/editable-field.hbs | 5 ++- web/app/styles/components/editable-field.scss | 2 +- .../components/editable-field-test.ts | 39 ++++++++++++++----- 3 files changed, 34 insertions(+), 12 deletions(-) diff --git a/web/app/components/editable-field.hbs b/web/app/components/editable-field.hbs index 42763813a..845454f1b 100644 --- a/web/app/components/editable-field.hbs +++ b/web/app/components/editable-field.hbs @@ -13,14 +13,15 @@ {{else}} {{#if (or @isSaving @isLoading)}}
- +
{{/if}} {{#unless @isLoading}} diff --git a/web/app/styles/components/editable-field.scss b/web/app/styles/components/editable-field.scss index b0ca24e0c..be0313128 100644 --- a/web/app/styles/components/editable-field.scss +++ b/web/app/styles/components/editable-field.scss @@ -11,7 +11,7 @@ cursor: default; } - &.loading { + &.saving { opacity: 0.5; } diff --git a/web/tests/integration/components/editable-field-test.ts b/web/tests/integration/components/editable-field-test.ts index 9b57116c0..f271e5b68 100644 --- a/web/tests/integration/components/editable-field-test.ts +++ b/web/tests/integration/components/editable-field-test.ts @@ -4,7 +4,6 @@ import { render, triggerEvent, triggerKeyEvent, - waitUntil, } from "@ember/test-helpers"; import { hbs } from "ember-cli-htmlbars"; import { MirageTestContext } from "ember-cli-mirage/test-support"; @@ -13,11 +12,12 @@ import { module, test } from "qunit"; const EDITABLE_FIELD_SELECTOR = ".editable-field"; const FIELD_TOGGLE_SELECTOR = ".editable-field .field-toggle"; -const LOADING_SPINNER_SELECTOR = ".loading-indicator"; +const LOADING_SPINNER_SELECTOR = `${EDITABLE_FIELD_SELECTOR} [data-test-spinner]`; interface EditableFieldComponentTestContext extends MirageTestContext { onChange: (value: any) => void; isLoading: boolean; + isSaving: boolean; value: string; newArray: string[]; } @@ -77,31 +77,52 @@ module("Integration | Component | editable-field", function (hooks) { assert.dom(EDITABLE_FIELD_SELECTOR).exists({ count: 1 }).hasText("foo two"); }); - test("it can show a loading state", async function (this: EditableFieldComponentTestContext, assert) { - this.set("isLoading", true); + test("it can show a saving state", async function (this: EditableFieldComponentTestContext, assert) { + this.set("isSaving", true); await render(hbs` `); - assert.dom(FIELD_TOGGLE_SELECTOR).hasClass("loading").isDisabled(); - + assert.dom(FIELD_TOGGLE_SELECTOR).hasClass("saving").isDisabled(); assert.dom(LOADING_SPINNER_SELECTOR).exists(); - this.set("isLoading", false); + this.set("isSaving", false); assert .dom(FIELD_TOGGLE_SELECTOR) - .doesNotHaveClass("loading") + .doesNotHaveClass("saving") .isNotDisabled(); assert.dom(LOADING_SPINNER_SELECTOR).doesNotExist(); }); + test("it can show a loading state", async function (this: EditableFieldComponentTestContext, assert) { + this.set("isLoading", true); + + await render(hbs` + + `); + + assert + .dom(FIELD_TOGGLE_SELECTOR) + .doesNotExist("content is not yielded while loading"); + assert.dom(LOADING_SPINNER_SELECTOR).exists(); + + this.set("isLoading", false); + + assert.dom(LOADING_SPINNER_SELECTOR).doesNotExist(); + assert.dom(FIELD_TOGGLE_SELECTOR).exists(); + }); + test("it yields an emptyValueErrorIsShown property to the editing block", async function (this: EditableFieldComponentTestContext, assert) { await render(hbs` Date: Mon, 11 Sep 2023 11:25:59 -0400 Subject: [PATCH 5/7] Remove console.logs --- web/app/components/document/sidebar.ts | 3 --- web/app/routes/authenticated/document.ts | 1 - 2 files changed, 4 deletions(-) diff --git a/web/app/components/document/sidebar.ts b/web/app/components/document/sidebar.ts index f29de0af7..d388de73b 100644 --- a/web/app/components/document/sidebar.ts +++ b/web/app/components/document/sidebar.ts @@ -555,9 +555,6 @@ export default class DocumentSidebarComponent extends Component Date: Mon, 18 Sep 2023 17:27:07 -0400 Subject: [PATCH 6/7] Add created types --- web/app/types/document.d.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/web/app/types/document.d.ts b/web/app/types/document.d.ts index bb7cb2da0..dcd60e76e 100644 --- a/web/app/types/document.d.ts +++ b/web/app/types/document.d.ts @@ -5,6 +5,8 @@ export interface HermesDocument { status: string; product?: string; + created: string; // E.g., "Aug 16, 2023" + createdTime: number; modifiedTime?: number; // Not available on drafts fetched as Hits from backend docNumber: string; docType: string; From 6712e10c0e34cb53af1b76d441128524a53228ae Mon Sep 17 00:00:00 2001 From: Jeff Daley Date: Mon, 18 Sep 2023 17:47:53 -0400 Subject: [PATCH 7/7] Clarify types --- web/app/components/document/sidebar.hbs | 2 +- web/app/components/row-results.hbs | 2 +- web/app/helpers/parse-date.ts | 7 ++----- web/app/types/document.d.ts | 21 +++++++++++++++++++-- 4 files changed, 23 insertions(+), 9 deletions(-) diff --git a/web/app/components/document/sidebar.hbs b/web/app/components/document/sidebar.hbs index d59caa1d1..09331a5f9 100644 --- a/web/app/components/document/sidebar.hbs +++ b/web/app/components/document/sidebar.hbs @@ -285,7 +285,7 @@
-

{{or @document.created "Unknown"}}

+

{{or (parse-date @document.created "long") "Unknown"}}

diff --git a/web/app/components/row-results.hbs b/web/app/components/row-results.hbs index df8d25010..fbac6639f 100644 --- a/web/app/components/row-results.hbs +++ b/web/app/components/row-results.hbs @@ -31,7 +31,7 @@ {{#each @docs as |doc|}} ( - ([time, monthFormat = "short"]: [ - string | number | Date | undefined, - undefined | "short" | "long" - ]) => { + ([time, monthFormat = "short"]) => { return parseDate(time, monthFormat); } ); diff --git a/web/app/types/document.d.ts b/web/app/types/document.d.ts index dcd60e76e..0f1eba0e8 100644 --- a/web/app/types/document.d.ts +++ b/web/app/types/document.d.ts @@ -5,9 +5,26 @@ export interface HermesDocument { status: string; product?: string; - created: string; // E.g., "Aug 16, 2023" + + /** + * A human-readable date string, e.g., "Aug 16, 2028". + * Mutated in the layout by the `parse-date` helper to place + * the date before the month. + */ + created: string; + + /** + * A timestamp in seconds. Used for sorting. + */ createdTime: number; - modifiedTime?: number; // Not available on drafts fetched as Hits from backend + + /** + * A timestamp in seconds. Used Translated by the `time-ago` helper + * into a human-readable string, e.g., "2 days ago." + * Not available on drafts fetched as Hits from backend. + */ + modifiedTime?: number; + docNumber: string; docType: string; title: string;