Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we fork and embed h5ai-nginx subrepo? #82

Closed
acuarica opened this issue Nov 28, 2023 · 1 comment
Closed

Should we fork and embed h5ai-nginx subrepo? #82

acuarica opened this issue Nov 28, 2023 · 1 comment

Comments

@acuarica
Copy link
Contributor

Currently some UI changes are applied to the subrepo. This changes are made by applying a patch, which leaves the repo as dirty.

Instead of this approach should we fork the h5ai-nginx subrepo and apply and commit those changes?
@acuarica
Copy link
Contributor Author

Closing this for now given that the patch approach is working fine at the moment and it doesn't prevent to customize it

@acuarica acuarica closed this as not planned Won't fix, can't repro, duplicate, stale Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@acuarica