Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove repository patch when upstream fix is merged #189

Closed
acuarica opened this issue May 31, 2024 · 1 comment · Fixed by #194
Closed

Remove repository patch when upstream fix is merged #189

acuarica opened this issue May 31, 2024 · 1 comment · Fixed by #194
Assignees
@acuarica

Comments

@acuarica
Copy link
Contributor

After sourcifyeth/h5ai-nginx#6 gets merged, we can update the submodule and remove the repository patch.
@acuarica acuarica self-assigned this May 31, 2024
@acuarica acuarica moved this to Tasks In Progress in Smart Contract Sprint Board May 31, 2024
@acuarica acuarica moved this from Tasks In Progress to Blocked in Smart Contract Sprint Board May 31, 2024
@acuarica
Copy link
Contributor Author

acuarica commented Jun 5, 2024

The above mentioned PR was merged sourcifyeth/h5ai-nginx#6 (review), so our custom repository patch is not needed anymore.

@acuarica acuarica mentioned this issue Jun 5, 2024
Merged
@acuarica acuarica linked a pull request Jun 5, 2024 that will close this issue
chore: remove the repository patch given the patch was included upstream #194
Merged
@acuarica acuarica moved this from Blocked to In Review in Smart Contract Sprint Board Jun 5, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Smart Contract Sprint Board Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acuarica acuarica

Labels
None yet
Projects
Smart Contract Sprint Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove the repository patch given the patch was included upstream hashgraph/hedera-sourcify
1 participant
@acuarica