From 7dd9fb5713c3d5f135aa3ece0426622a07851cc4 Mon Sep 17 00:00:00 2001 From: beeradb <294617+beeradb@users.noreply.github.com> Date: Tue, 4 Jun 2024 15:20:46 -0400 Subject: [PATCH] Code review feedback Signed-off-by: beeradb <294617+beeradb@users.noreply.github.com> --- charts/templates/server-repository/configmap.yaml | 6 ------ charts/templates/server-repository/deployment.yaml | 3 --- charts/values.yaml | 6 ------ 3 files changed, 15 deletions(-) diff --git a/charts/templates/server-repository/configmap.yaml b/charts/templates/server-repository/configmap.yaml index 2d15eb54..517c4a0a 100644 --- a/charts/templates/server-repository/configmap.yaml +++ b/charts/templates/server-repository/configmap.yaml @@ -12,10 +12,6 @@ metadata: data: SERVER_URL: {{ .Values.serverRepository.config.SERVER_URL }} REPOSITORY_SERVER_URL: {{ .Values.serverRepository.config.REPOSITORY_SERVER_URL }} - SERVER_PORT: {{ .Values.serverRepository.service.server.port | quote }} - SERVER_EXTERNAL_PORT: {{ .Values.serverRepository.service.server.port | quote }} - REPOSITORY_SERVER_PORT: {{ .Values.serverRepository.service.repository.port | quote }} - REPOSITORY_SERVER_EXTERNAL_PORT: {{ .Values.serverRepository.service.repository.port | quote }} NODE_ENV: {{ .Values.serverRepository.config.NODE_ENV | default "development" }} SOURCIFY_SERVER: "http://{{ template "sourcify.name" . }}-server:5555" --- @@ -31,8 +27,6 @@ metadata: {{ toYaml .Values.serverRepository.annotations | indent 4 }} {{- end }} data: - config.json: |- - {{- .Values.serverRepository.config.repository | toJson | nindent 4 }} servers.yaml: |- {{- .Values.serverRepository.config.servers | toYaml | nindent 4 }} sourcify-chains.json: |- diff --git a/charts/templates/server-repository/deployment.yaml b/charts/templates/server-repository/deployment.yaml index 498121d5..d151cafb 100644 --- a/charts/templates/server-repository/deployment.yaml +++ b/charts/templates/server-repository/deployment.yaml @@ -105,9 +105,6 @@ spec: - name: {{ .Chart.Name }} mountPath: /data readOnly: true - - name: {{ printf "%s-%s" .Chart.Name "repository" }} - mountPath: /redirects/config.json - subPath: config.json {{- if .Values.serverRepository.nodeSelector }} nodeSelector: {{- toYaml .Values.serverRepository.nodeSelector | nindent 8 }} diff --git a/charts/values.yaml b/charts/values.yaml index 1e725641..5844faf0 100644 --- a/charts/values.yaml +++ b/charts/values.yaml @@ -77,12 +77,6 @@ serverRepository: SERVER_URL: "http://127.0.0.1:5555" REPOSITORY_SERVER_URL: "http://127.0.0.1:10000" NODE_ENV: "production" - repository: - { - "SERVER_URL": "http://127.0.0.1:5555", - "REPOSITORY_SERVER_URL": "http://127.0.0.1:10000", - "EXPLORER_URL": "http://127.0.0.1:8080", - } servers: - description: The current REST API server url: ""