fix: enhanced reliability of eth RPC methods with null checks and retry mechanisms #3349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 20 files - 4 312 suites - 49 38m 13s ⏱️ - 22m 7s For more details on these failures, see this check. Results for commit 051f326. ± Comparison against base commit 90739e1. This pull request removes 6 tests.♻️ This comment has been updated with latest results. |
quiet-node
force-pushed
the
3346-failed-request-alert-tuning-investigate-and-resolve-the-bug-causing-the-received-an-invalid-integer-type-null-error-in-ethimplgetblock-function
branch
from
675eb4a to
d265305
Compare
Nana-EC
reviewed
Dec 21, 2024
packages/relay/src/lib/services/ethService/ethCommonService/index.ts
Outdated
Show resolved
Hide resolved
acuarica
reviewed
Dec 21, 2024
quiet-node
force-pushed
the
3346-failed-request-alert-tuning-investigate-and-resolve-the-bug-causing-the-received-an-invalid-integer-type-null-error-in-ethimplgetblock-function
branch
from
936f1e9 to
b959fc7
Compare
Nana-EC
reviewed
Dec 21, 2024
quiet-node
force-pushed
the
3346-failed-request-alert-tuning-investigate-and-resolve-the-bug-causing-the-received-an-invalid-integer-type-null-error-in-ethimplgetblock-function
branch
from
19d9838 to
e1c8fd0
Compare
quiet-node
force-pushed
the
3346-failed-request-alert-tuning-investigate-and-resolve-the-bug-causing-the-received-an-invalid-integer-type-null-error-in-ethimplgetblock-function
branch
7 times, most recently
from
3b96fc4 to
aad493c
Compare
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
quiet-node
force-pushed
the
3346-failed-request-alert-tuning-investigate-and-resolve-the-bug-causing-the-received-an-invalid-integer-type-null-error-in-ethimplgetblock-function
branch
2 times, most recently
from
a5a0e1f to
78fa644
Compare
…Contract MN methods Signed-off-by: Logan Nguyen <[email protected]>
quiet-node
force-pushed
the
3346-failed-request-alert-tuning-investigate-and-resolve-the-bug-causing-the-received-an-invalid-integer-type-null-error-in-ethimplgetblock-function
branch
from
bac3c74 to
d7f5829
Compare
quiet-node
commented
Dec 23, 2024
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]> Revert "fix: reverted licenses" This reverts commit d3c860a. Reapply "fix: reverted licenses" This reverts commit 50a9acd5031490f3f805042a70bfdae7c589146d.
Signed-off-by: Logan Nguyen <[email protected]>
quiet-node
force-pushed
the
3346-failed-request-alert-tuning-investigate-and-resolve-the-bug-causing-the-received-an-invalid-integer-type-null-error-in-ethimplgetblock-function
branch
from
d6756f0 to
8687322
Compare
quiet-node
changed the title
acuarica
reviewed
Jan 6, 2025
Nana-EC
requested review from
konstantinabl and
nadezhdapopovaa
and removed request for
stoyanov-st
natanasow
reviewed
Jan 7, 2025
…k_hash is empty Signed-off-by: Logan Nguyen <[email protected]>
quiet-node
force-pushed
the
3346-failed-request-alert-tuning-investigate-and-resolve-the-bug-causing-the-received-an-invalid-integer-type-null-error-in-ethimplgetblock-function
branch
from
9f2e473 to
051f326
Compare
|
natanasow
approved these changes
Jan 8, 2025
Nana-EC
approved these changes
Jan 9, 2025
quiet-node
deleted the
3346-failed-request-alert-tuning-investigate-and-resolve-the-bug-causing-the-received-an-invalid-integer-type-null-error-in-ethimplgetblock-function
branch
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3349 +/- ##
==========================================
- Coverage 85.30% 84.83% -0.47%
==========================================
Files 69 69
Lines 4688 4721 +33
Branches 1050 1063 +13
==========================================
+ Hits 3999 4005 +6
- Misses 374 399 +25
- Partials 315 317 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
quiet-node
added a commit
that referenced
this pull request
Jan 9, 2025
…ry mechanisms (#3349) * fix: fixed flaky precheck test Signed-off-by: Logan Nguyen <[email protected]> * fix: handle log null entities more gracefully in getBlock() Signed-off-by: Logan Nguyen <[email protected]> * fix: added null check to root hash builder Signed-off-by: Logan Nguyen <[email protected]> * fix: modified getContractResultWithRetry() to accept more general getContract MN methods Signed-off-by: Logan Nguyen <[email protected]> * fix: reused getContractResultWithRetry for getContractResults Signed-off-by: Logan Nguyen <[email protected]> * fix: added getContractResultsLogsWithRetry() Signed-off-by: Logan Nguyen <[email protected]> * fix: reverted licenses Signed-off-by: Logan Nguyen <[email protected]> Revert "fix: reverted licenses" This reverts commit d3c860a. Reapply "fix: reverted licenses" This reverts commit 50a9acd5031490f3f805042a70bfdae7c589146d. * fix: checked empty blockHash for getHistoricalBlockResponse() Signed-off-by: Logan Nguyen <[email protected]> * fix: throw error if log.block_number or log.index is null or log.block_hash is empty Signed-off-by: Logan Nguyen <[email protected]> --------- Signed-off-by: Logan Nguyen <[email protected]>
2 tasks
quiet-node
added a commit
that referenced
this pull request
Jan 9, 2025
…ds with null checks and retry mechanisms to release/0.63 (#3363) fix: enhanced reliability of eth RPC methods with null checks and retry mechanisms (#3349) * fix: fixed flaky precheck test * fix: handle log null entities more gracefully in getBlock() * fix: added null check to root hash builder * fix: modified getContractResultWithRetry() to accept more general getContract MN methods * fix: reused getContractResultWithRetry for getContractResults * fix: added getContractResultsLogsWithRetry() * fix: reverted licenses Revert "fix: reverted licenses" This reverts commit d3c860a. Reapply "fix: reverted licenses" This reverts commit 50a9acd5031490f3f805042a70bfdae7c589146d. * fix: checked empty blockHash for getHistoricalBlockResponse() * fix: throw error if log.block_number or log.index is null or log.block_hash is empty --------- Signed-off-by: Logan Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Numerous requests for
eth_getBlockByNumberandeth_getBlockByHashhave been reported as failing with errors such asCannot read properties of nullandReceived an invalid integer type: null.Additionally,
eth_getTransactionReceiptis also reported to be failing withError invoking RPC: Invalid parameter: hashOrNumber.These issues stem from regressions in the
getBlock()method, which lacks adequate null checks in certain areas. This pull request addresses the problem by implementing proper null checks and enhancing fallback mechanisms and error handling.Partially, the results of contracts and log responses from the Mirror Node occasionally contain undefined fields, such as transaction_index, block_hash, block_number, and log_index. This issue may arise because the Mirror Node database does not have sufficient time to save all the information before it is fetched. This PR adds a retry mechanism to the fetching methods that checks for these cases, waits for a specified duration, and then retries the fetch operation.
Related issue(s):
Fixes #3345
Fixes #3351
Notes for reviewer:
Checklist