Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relay throws an "IP rate limit exceeded ..." exception, regardless of whether it's an IP-related rate issue #3336

Open
Neurone opened this issue Dec 13, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Neurone
Copy link
Contributor

Neurone commented Dec 13, 2024

Description

The relay throws an exception to the client saying “IP rate limit exceeded …” regardless of whether it's a real IP rate limit applied by the relay or an RPS rate limit applied by the MN. I.e:

{"error":{"code":-32605,"message":"[Request ID: 6dcd2378-defa-47d2-8de6-74c3bdfc6600] IP Rate limit exceeded on Rate limit exceeded on eth_call"},"jsonrpc":"2.0","id":72}'

While providers can apply IP rate limits on their gateway when serving an MN (i.e. this is what the public mirror node service does), the mirror node itself does not apply limits but for the mirror-node-web3 container.

In that case, a throttling based on the RPS is applied, regardless of the client's IP. The setting can be changed using the hedera.mirror.web3.throttle.requestsPerSecond parameter (default: 500).

Steps to reproduce

  1. Disable the rate limits in the JSON-RPC relay setting RATE_LIMIT_DISABLED=true
  2. Hit the /api/v1/contracts/call relay endpoint multiple times per second
  3. See the "IP Rate limit exceeded on Rate limit exceeded on eth_call" error appears.

Additional context

No response

Hedera network

other

Version

v0.61.0

Operating system

None

@Neurone Neurone added the bug Something isn't working label Dec 13, 2024
@Neurone Neurone changed the title Relay throws an “IP rate limit exceeded …” exception regardless if it's an IP-related rate issue. Relay throws an "IP rate limit exceeded ..." exception, regardless of whether it's an IP-related rate issue Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant