Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable jvm linting flags to assess if there's an issue #422

Open
Tracked by #392
mattp-swirldslabs opened this issue Dec 18, 2024 · 0 comments
Open
Tracked by #392
Labels
Block Node Issues/PR related to the Block Node. Improvement Code changes driven by non business requirements

Comments

@mattp-swirldslabs
Copy link
Contributor

mattp-swirldslabs commented Dec 18, 2024

As a Block Node developer
I want to enable the jvm linting flags in com.hedera.block.conventions.gradle.kts
So that we can assess whether the observed warnings are actually a concern

  • While Working on Configure gradle to build deterministically #408, we observed that adding the following line to the JavaCompile options object of the Gradle config lifted the suppression on java module warnings throughout the system.
  • This ticket would be to re-examine those warnings and evaluate if they should be fixed and the linting options should remain enabled in the project
options.compilerArgs.add("-Xlint:all,-" + deactivatedCompileLintOptions.joinToString(",-"))

Relative location within the file:

    options.encoding = "UTF-8"
    options.isFork = true // run compiler in separate JVM process (independent of toolchain setup)
    options.compilerArgs.add("-implicit:none")
    options.compilerArgs.add("-Xlint:all,-" + deactivatedCompileLintOptions.joinToString(",-"))
@mattp-swirldslabs mattp-swirldslabs added Improvement Code changes driven by non business requirements Block Node Issues/PR related to the Block Node. labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Block Node Issues/PR related to the Block Node. Improvement Code changes driven by non business requirements
Projects
None yet
Development

No branches or pull requests

1 participant