Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: deterministic docker changes part 1 #419

Merged
merged 25 commits into from
Dec 18, 2024
Merged

feat: deterministic docker changes part 1 #419

merged 25 commits into from
Dec 18, 2024

Conversation

mattp-swirldslabs
Copy link
Contributor

@mattp-swirldslabs mattp-swirldslabs commented Dec 17, 2024 •
edited
Loading

Description:

  • Added Dockerfile determinism directives
  • Added workflow entry point... another PR to come

Related issue(s):

Fixes #409

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@mattp-swirldslabs mattp-swirldslabs self-assigned this Dec 17, 2024
@mattp-swirldslabs mattp-swirldslabs added the Block Node Issues/PR related to the Block Node. label Dec 17, 2024
@mattp-swirldslabs mattp-swirldslabs added this to the 0.4.0 milestone Dec 17, 2024
@mattp-swirldslabs mattp-swirldslabs marked this pull request as ready for review December 17, 2024 20:26
@mattp-swirldslabs mattp-swirldslabs requested review from a team as code owners December 17, 2024 20:26
@mattp-swirldslabs mattp-swirldslabs force-pushed the 00409-deterministic-docker-changes branch from 6fe0ac3 to 1b6bea3 Compare December 17, 2024 20:34
AlfredoG87
AlfredoG87 previously approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattp-swirldslabs mattp-swirldslabs changed the title feat: deterministic docker changes feat: deterministic docker changes part 1 Dec 17, 2024
jsync-swirlds
jsync-swirlds previously approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@jsync-swirlds jsync-swirlds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking, but we should upgrade the Java version (both in scripts and in the dockerfile); and I have a few questions and suggestions for future improvements (e.g. part 2).

.github/workflows/release-push-image.yaml Show resolved Hide resolved
.github/workflows/zxc-verify-docker-build-determinism.yaml Show resolved Hide resolved
.github/workflows/zxc-verify-gradle-build-determinism.yaml Show resolved Hide resolved
gradlew.bat Show resolved Hide resolved
server/docker/Dockerfile Show resolved Hide resolved
server/docker/Dockerfile Show resolved Hide resolved
@mattp-swirldslabs mattp-swirldslabs force-pushed the 00409-deterministic-docker-changes branch from 6aea538 to 8727877 Compare December 18, 2024 14:41
@mattp-swirldslabs
fix: first test
396410b 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
fix: adjusted the runner
2a1b811 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
fix: replaced print step with actual steps
9331e1f 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
fix: calling script to generate manifest
a81ce5e 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
fix: upgraded gradlew to v8.11.1
6f6877c 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
fix: enabling more bash script steps
ee90e77 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
fix: adding additional bash script steps
59830ac 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
fix: comment out libs and change app jar path
1f3d122 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
fix: debugging and generating application hashes
942fea6 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
fix: adjusting hashes
e45a462 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
fix: setting up baselines
f50642a 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
fix: added verify-artifacts step
c68095c 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
fix: added python, stubbed download
6e1d432 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
fix: added GRADLE_MANIFEST_PATH
825e1b9 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
fix: fixed 2 os types
e8eda37 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
fix: fixed validation path
07a721e 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
fix: removed unnecessary lib manifest options
32517dc 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
fix: Refactored Dockerfile to use deterministic directives
1a6e6ac 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
fix: removed backslash
19c6034 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
fix: Dockerfile fixes
b67f948 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
wip: testing new workflow integration
4f061a9 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
wip: added debug echo
e751f69 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
fix: comment out the docker verification in the short term
5511992 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
fix: added curl dep back in to fix health check
df4084e 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs
fix: removing jvm lint option
9af03fb 
Signed-off-by: Matt Peterson <[email protected]>
@mattp-swirldslabs mattp-swirldslabs force-pushed the 00409-deterministic-docker-changes branch from 8727877 to 9af03fb Compare December 18, 2024 16:26
@mattp-swirldslabs mattp-swirldslabs merged commit 7a6702a into main Dec 18, 2024
9 checks passed
@mattp-swirldslabs mattp-swirldslabs deleted the 00409-deterministic-docker-changes branch December 18, 2024 20:53
@codecov Codecov
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.02%. Comparing base (27d3197) to head (9af03fb).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main     #419   +/-   ##
=========================================
  Coverage     97.02%   97.02%           
  Complexity      409      409           
=========================================
  Files            82       82           
  Lines          1446     1446           
  Branches         89       89           
=========================================
  Hits           1403     1403           
  Misses           32       32           
  Partials         11       11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsync-swirlds jsync-swirlds jsync-swirlds left review comments

@rbarkerSL rbarkerSL rbarkerSL approved these changes

@AlfredoG87 AlfredoG87 AlfredoG87 approved these changes

@andrewb1269hg andrewb1269hg Awaiting requested review from andrewb1269hg andrewb1269hg is a code owner automatically assigned from hashgraph/devops-ci

@jeromy-cannon jeromy-cannon Awaiting requested review from jeromy-cannon jeromy-cannon is a code owner automatically assigned from hashgraph/release-engineering-managers

Assignees

@mattp-swirldslabs mattp-swirldslabs

Labels
Block Node Issues/PR related to the Block Node.
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

Configure the Block Node Dockerfile to build deterministic images
4 participants
@mattp-swirldslabs @jsync-swirlds @AlfredoG87 @rbarkerSL