Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: translate the donate modal to English #973

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

yontank
Copy link
Collaborator

@yontank yontank commented Dec 11, 2024

Description

translates DonateModal to English when switching languages, also change Donate modal from LTR to RTL depending on the language specification

@yontank yontank requested a review from NoamGaash as a code owner December 11, 2024 17:21
Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!


return (
<Modal
dir={i18n.dir()}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a way to use global css rules to achive this behavior without inserting inline style to individual components?
If you don't know, I'd appreciate if you can open an issue to investigate it after we'll merge this one

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, Might be better to open an Issue about it but I can probably learn and do it alone

@NoamGaash NoamGaash changed the title remove commented code feat: translate the donate modal to English Dec 11, 2024
@NoamGaash
Copy link
Member

run npm run lint:fix or npm run lint -- --fix to fix lint errors :)

@NoamGaash
Copy link
Member

small comment -
image

the colon (:) is aligned to the left instead to the right (should come directly after the field name)
The other changes (חשבון vs החשבון) are completely fine :)
Thank you very much!

Copy link
Collaborator Author

@yontank yontank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment -
image

the colon (:) is aligned to the left instead to the right (should come directly after the field name)
The other changes (חשבון vs החשבון) are completely fine :)
Thank you very much!

yeah you're right, my bad!

Copy link
Collaborator Author

@yontank yontank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, Might be better to open an Issue about it but I can probably learn and do it alone

Yeah, I don't really know what to do here 🤦‍♂️, I'll open an Issue and merge it with the fixes and write some tests for the Modal.

Does everything look ok for a merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants