-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: translate the donate modal to English #973
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much!
|
||
return ( | ||
<Modal | ||
dir={i18n.dir()} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a way to use global css rules to achive this behavior without inserting inline style to individual components?
If you don't know, I'd appreciate if you can open an issue to investigate it after we'll merge this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, Might be better to open an Issue about it but I can probably learn and do it alone
run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, Might be better to open an Issue about it but I can probably learn and do it alone
Yeah, I don't really know what to do here 🤦♂️, I'll open an Issue and merge it with the fixes and write some tests for the Modal.
Does everything look ok for a merge?
Description
translates DonateModal to English when switching languages, also change Donate modal from LTR to RTL depending on the language specification