Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: move element to the right #965

Merged
merged 6 commits into from
Dec 8, 2024
Merged

style: move element to the right #965

merged 6 commits into from
Dec 8, 2024

Conversation

rivka14
Copy link
Collaborator

@rivka14 rivka14 commented Dec 5, 2024

The sidebar toggle button's position align to the right side.

@rivka14 rivka14 self-assigned this Dec 5, 2024
@rivka14 rivka14 requested a review from NoamGaash as a code owner December 5, 2024 20:05
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024 •
edited
Loading

Preview: https://s3.amazonaws.com/noam-gaash.co.il/12220618486/open-bus/205/index.html
Preview Storybook: https://s3.amazonaws.com/noam-gaash.co.il/12220618486/open-bus/205/storybook/index.html
Test Report (if available): 'https://s3.amazonaws.com/noam-gaash.co.il/12220618486/open-bus/f61c05dfb0a5074620a45fe83249b55483499304/test-results/index.html'

@rivka14 rivka14 assigned rivka14 and unassigned rivka14 Dec 6, 2024
@NoamGaash NoamGaash changed the title Move element to the right style: move element to the right Dec 6, 2024
@NoamGaash
Copy link
Member

Hi, thanks for submitting this pull request!
Did you check the layout when switching the language?
I believe display: flex could do a better job here

@rivka14
Copy link
Collaborator Author

rivka14 commented Dec 7, 2024

@NoamGaash thanks for your feedback! I've made the following updates based on your suggestions:

  • Ensured proper layout when switching languages.
  • Updated to use flexbox .

Is everything good now?
Thank you so much for your help!

@NoamGaash
Copy link
Member

@rivka14 perfect, thank you! 👏 🚌
would you please just remove the yarn.lock file?

NoamGaash
NoamGaash approved these changes Dec 8, 2024
View reviewed changes
Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👏 🙏

@rivka14 rivka14 merged commit e3cebee into hasadna:main Dec 8, 2024
13 checks passed
@NoamGaash
Copy link
Member

Thank you @rivka14 !
@all-contributors please add @rivka14 to code :)

@allcontributors allcontributors bot mentioned this pull request Dec 9, 2024
Open
@allcontributors AllContributors
Copy link
Contributor

@NoamGaash

I've put up a pull request to add @rivka14! 🎉

@rivka14 rivka14 deleted the issue-897-move-right branch December 10, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoamGaash NoamGaash NoamGaash approved these changes

Assignees

@rivka14 rivka14

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rivka14 @NoamGaash