chore: add ngnix security headers #964
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoamGaash
reviewed
Dec 5, 2024
nginx-default.conf
Outdated
Comment on lines
16
to
19
| # CORS settings | ||
| add_header Access-Control-Allow-Origin "self https://www.google-analytics.com https://www.googletagmanager.com https://fonts.gstatic.com https://fonts.googleapis.com *.hasadna.org.il"; | ||
| add_header Access-Control-Allow-Methods "GET, POST, OPTIONS"; | ||
| add_header Access-Control-Allow-Headers "Origin, X-Requested-With, Content-Type, Accept"; |
There was a problem hiding this comment.
Thank you!
But regarding CORS settings - is it needed? I was under the impression that CORS is blocked by default for all origins, and that google analytics and google fonts doesn't need to be included here.
There was a problem hiding this comment.
sure, will remove # CORS settings section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request for issue #939 updates the Nginx configuration to enhance security and allow communication with specific origins. The changes include:
Security Headers: Added headers to prevent MIME type sniffing, clickjacking, and XSS attacks.
Content Security Policy (CSP): Configured to restrict resources to specific trusted domains, including Google Analytics, Google Fonts, and hasadna.org.il.
CORS Configuration: Updated to allow cross-origin requests from specified domains.
screenshots