Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

component/widget #283

Merged
merged 6 commits into from
Dec 10, 2023
Merged

component/widget #283

merged 6 commits into from
Dec 10, 2023

Conversation

yardenmezi
Copy link
Collaborator

@yardenmezi yardenmezi commented Dec 7, 2023 •
edited
Loading

No description provided.

@yardenmezi yardenmezi self-assigned this Dec 7, 2023
@yardenmezi yardenmezi linked an issue Dec 7, 2023 that may be closed by this pull request
create a Widget component #245
Closed
@yardenmezi yardenmezi requested a review from shootermv December 7, 2023 16:37
@yardenmezi yardenmezi marked this pull request as ready for review December 7, 2023 16:39
@yardenmezi yardenmezi requested a review from NoamGaash as a code owner December 7, 2023 16:39
@shootermv
Copy link
Contributor

well done @yardenmezi !

shootermv
shootermv suggested changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@shootermv shootermv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can i ask you to create storybook test too?

@NoamGaash
Copy link
Member

NoamGaash commented Dec 7, 2023 •
edited
Loading

Hi, I dont fully understand- seems like you've added a component but didn't use it

@shootermv shootermv self-requested a review December 8, 2023 13:05
@NoamGaash
Copy link
Member

the code looks great 👍

shootermv
shootermv approved these changes Dec 10, 2023
View reviewed changes
Copy link
Contributor

@shootermv shootermv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done!

@shootermv shootermv merged commit 1d6d636 into hasadna:main Dec 10, 2023
9 checks passed
@github-actions github-actions bot mentioned this pull request Dec 18, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jun 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoamGaash NoamGaash NoamGaash approved these changes

@shootermv shootermv shootermv approved these changes

Assignees

@yardenmezi yardenmezi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

create a Widget component
3 participants
@yardenmezi @shootermv @NoamGaash