Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix gap sort by date #271

Merged
merged 4 commits into from
Dec 5, 2023
Merged

fix gap sort by date #271

merged 4 commits into from
Dec 5, 2023

Conversation

SergeyArenzon
Copy link
Contributor

@SergeyArenzon SergeyArenzon commented Dec 2, 2023 •
edited
Loading

Description

Solves [Bug] Sort Hours in Gaps Page #265
Fix for unsorted gaps with "נסיעה שלא תוכננה".
Now it should sort it with others gaps by its actual time.

before fix: unplanned rides unsorted with other rides
Screenshot 2023-12-02 at 20 11 12
after fix: unplanned rides sorted with other rides by its actual time.
Screenshot 2023-12-02 at 20 19 28

NoamGaash
NoamGaash approved these changes Dec 2, 2023
View reviewed changes
Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Would you like to create a test for it? It will help preventing regressions

shootermv
shootermv suggested changes Dec 3, 2023
View reviewed changes
Copy link
Contributor

@shootermv shootermv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the yarn.lock file should not change (since no new packages installed at this PR)

@SergeyArenzon
Copy link
Contributor Author

Looks great! Would you like to create a test for it? It will help preventing regressions

Ill do it.

@SergeyArenzon
Copy link
Contributor Author

i think the yarn.lock file should not change (since no new packages installed at this PR)

yarn.lock reverted back.

@NoamGaash NoamGaash requested a review from shootermv December 3, 2023 07:43
@NoamGaash
Copy link
Member

@SergeyArenzon
image
for next time - please be aware of this button :)

@shootermv shootermv requested a review from NoamGaash December 3, 2023 07:45
@shootermv
Copy link
Contributor

looks very good!
after merging the latest changes, i will be glad to merge the PR

@ArkadiK94 ArkadiK94 linked an issue Dec 5, 2023 that may be closed by this pull request
[Bug] Sort Hours in Gaps Page #265
Closed
@giladfuchs giladfuchs merged commit cee708e into hasadna:main Dec 5, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shootermv shootermv shootermv approved these changes

@NoamGaash NoamGaash Awaiting requested review from NoamGaash NoamGaash is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Sort Hours in Gaps Page
4 participants
@SergeyArenzon @NoamGaash @shootermv @giladfuchs