Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accessibility: Convert image links to buttons #949

Open
chaniBenziman opened this issue Nov 26, 2024 · 2 comments
Open

Improve accessibility: Convert image links to buttons #949

chaniBenziman opened this issue Nov 26, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request frontend frontend developers issue good first issue Good for newcomers hacktoberfest

Comments

@chaniBenziman
Copy link
Collaborator

chaniBenziman commented Nov 26, 2024

The current clickable image link for "לתרום לסדנא" ("Donate to the Workshop") has usability and accessibility issues:
image

1.Accessibility: Screen readers may not clearly convey its purpose.
2.Design: A button is more appropriate for a call-to-action.
Proposed changes:

-Replace the image with a button labeled "לתרומה לסדנא →" ("Donate to the Workshop →").
-Ensure the button is keyboard-accessible, styled consistently, and follows accessibility best practices.
Benefits:

-Better accessibility and usability.
-Aligns with modern UI/UX standards.

@NoamGaash NoamGaash added enhancement New feature or request good first issue Good for newcomers hacktoberfest frontend frontend developers issue labels Nov 27, 2024
@NoamGaash
Copy link
Member

NoamGaash commented Nov 27, 2024

Thank you for submitting this issue!
We have invited you to have write access in case you'll want to contribute code to this repo
@all-contributors please add @chaniBenziman for ideas

Copy link
Contributor

@NoamGaash

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend frontend developers issue good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants