Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add storybook stories to some of our components #892

Open
NoamGaash opened this issue Oct 6, 2024 · 3 comments
Open

Add storybook stories to some of our components #892

NoamGaash opened this issue Oct 6, 2024 · 3 comments
Labels
frontend frontend developers issue good first issue Good for newcomers hacktoberfest

Comments

@NoamGaash
Copy link
Member

Right now we do have a storybook for the components in this project, but only for a few, and the stories don't utilize all the features storybook has to offer (play functions, smart controls, etc.).
We will welcome any pull request improving the storybook.
By the way - there's an Easter egg 🥚 - type "storybook" anywhere in the website to get a link to the storybook
@NoamGaash NoamGaash added good first issue Good for newcomers hacktoberfest frontend frontend developers issue labels Oct 6, 2024
@griseduardo
Copy link
Collaborator

Hello @NoamGaash, could you allow write access in repository for me, please?

@NoamGaash
Copy link
Member Author

@griseduardo Sure! Thanks

@griseduardo
Copy link
Collaborator

griseduardo commented Oct 22, 2024 •
edited
Loading

Hello @NoamGaash, I opened a PR for DisplayGapsPercentage component documentation here: #896

@griseduardo griseduardo mentioned this issue Oct 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
frontend frontend developers issue good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NoamGaash @griseduardo