Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove annoying console.log statements in the code #200

Closed
shootermv opened this issue Nov 12, 2023 · 5 comments · Fixed by #206
Closed

remove annoying console.log statements in the code #200

shootermv opened this issue Nov 12, 2023 · 5 comments · Fixed by #206
Labels
good first issue Good for newcomers

Comments

@shootermv
Copy link
Contributor

shootermv commented Nov 12, 2023

when you open chrome dev tool (or firefox dev tool or edge) you can see a lot of console stuff
which is better not to be there
image

@shootermv shootermv changed the title remove annoying consoel.log statement in the code remove annoying console.log statement in the code Nov 12, 2023
@shootermv shootermv changed the title remove annoying console.log statement in the code remove annoying console.log statements in the code Nov 12, 2023
@shootermv shootermv added the good first issue Good for newcomers label Nov 12, 2023
@codeomi
Copy link

codeomi commented Nov 12, 2023

having trouble pushing the code
remote: Permission to hasadna/open-bus-map-search.git denied to omkarFintaar.

@Abhid1239
Copy link
Contributor

Hey, @shootermv can you please review my PR and approve it.

@shootermv
Copy link
Contributor Author

shootermv commented Nov 13, 2023

hi @Abhid1239 !
glad to see you joined us in our project!
For create a PR, you need:

  1. create a fork (by pressing fork button at github repo)
  2. clone a project on your machine (git clone https://github.com/hasadna/open-bus-map-search)
  3. connect you local project to remote repo (git remote set-url origin https://github.com/YOUR-NICKNAME/open-bus-map-search)
  4. create a branch with your changes
    only then you will be able to create a PR
    please read contribution section (or some how to contribute to open source guide)

@Abhid1239
Copy link
Contributor

Hey @shootermv thanks for the detailed info.

Have created the the branch first and then created the PR please check

NoamGaash pushed a commit that referenced this issue Nov 13, 2023
@NoamGaash NoamGaash linked a pull request Nov 13, 2023 that will close this issue
@NoamGaash
Copy link
Member

thanks @Abhid1239 ! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants