Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: verify clean tree #106

Closed
NoamGaash opened this issue Oct 10, 2023 · 2 comments · Fixed by #171
Closed

ci: verify clean tree #106

NoamGaash opened this issue Oct 10, 2023 · 2 comments · Fixed by #171
Assignees
@ArkadiK94
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Milestone
Test coverage

Comments

@NoamGaash
Copy link
Member

  1. if running yarn will make changes to the yarn.lock, CI should fail
  2. if we have a package-lock.json file in the root folder, CI should fail
  3. if running yarn run build created things outside the .gitignore, CI should fail

for example:
image
https://github.com/microsoft/playwright/actions/runs/6464306848/job/17548743565?pr=27519
@NoamGaash NoamGaash added enhancement New feature or request good first issue Good for newcomers hacktoberfest labels Oct 10, 2023
@NoamGaash NoamGaash added this to the Test coverage milestone Oct 16, 2023
@NoamGaash NoamGaash pinned this issue Oct 27, 2023
@ArkadiK94
Copy link
Collaborator

Pls, assign me, I would like to try it out. Honestly, for now, I don't know exactly how to do it but I want to research a solution.

@NoamGaash
Copy link
Member Author

good luck! @ArkadiK94
feel free to copy from playwright

@ArkadiK94 ArkadiK94 mentioned this issue Nov 4, 2023
Merged
@ArkadiK94 ArkadiK94 linked a pull request Nov 4, 2023 that will close this issue
[CI/CD] Check For Clean Tree #171
Merged
@ArkadiK94 ArkadiK94 unpinned this issue Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArkadiK94 ArkadiK94

Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
Test coverage
Development

Successfully merging a pull request may close this issue.

[CI/CD] Check For Clean Tree hasadna/open-bus-map-search
2 participants
@NoamGaash @ArkadiK94