Skip to content

Commit

Permalink
Fix overflow issue for mobile graph display (#250)
Browse files Browse the repository at this point in the history
  • Loading branch information
moshefortgang authored Nov 30, 2023
1 parent 7e8c160 commit f617794
Showing 1 changed file with 49 additions and 47 deletions.
96 changes: 49 additions & 47 deletions src/pages/gapsPatterns/GapsPatternsPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import {
ComposedChart,
Cell,
TooltipProps,
ResponsiveContainer,
} from 'recharts'
import { mapColorByExecution } from '../components/utils'
import { useGapsList } from '../useGapsList'
Expand Down Expand Up @@ -86,53 +87,54 @@ function GapsByHour({ lineRef, operatorRef, fromDate, toDate }: BusLineStatistic
<Radio.Button value="hour">{TEXTS.order_by_hour}</Radio.Button>
<Radio.Button value="severity">{TEXTS.order_by_severity} </Radio.Button>
</Radio.Group>

<ComposedChart
layout="vertical"
width={500}
height={hourlyData.length * 50}
data={hourlyData}
margin={{
top: 20,
right: 20,
bottom: 20,
left: 20,
}}
barGap={-20}>
<CartesianGrid stroke="#f5f5f5" />
<XAxis
type="number"
xAxisId={0}
reversed={true}
orientation={'top'}
domain={[0, maxHourlyRides]}
/>
<XAxis
type="number"
xAxisId={1}
reversed={true}
orientation={'top'}
domain={[0, maxHourlyRides]}
hide
/>
<YAxis
dataKey="planned_hour"
type="category"
orientation={'right'}
style={{ direction: 'ltr', marginTop: '-10px' }}
/>
<Tooltip content={<CustomTooltip />} />
<Legend />
<Bar dataKey="actual_rides" barSize={20} radius={9} xAxisId={1} opacity={30}>
{hourlyData.map((entry, index) => (
<Cell
key={`cell-${index}`}
fill={mapColorByExecution(entry.planned_rides, entry.actual_rides)}
/>
))}
</Bar>
<Bar dataKey="planned_rides" barSize={20} fill="#413ea055" radius={9} xAxisId={0} />
</ComposedChart>
<ResponsiveContainer width="100%" height={hourlyData.length * 50}>
<ComposedChart
layout="vertical"
width={500}
height={hourlyData.length * 50}
data={hourlyData}
margin={{
top: 20,
right: 20,
bottom: 20,
left: 20,
}}
barGap={-20}>
<CartesianGrid stroke="#f5f5f5" />
<XAxis
type="number"
xAxisId={0}
reversed={true}
orientation={'top'}
domain={[0, maxHourlyRides]}
/>
<XAxis
type="number"
xAxisId={1}
reversed={true}
orientation={'top'}
domain={[0, maxHourlyRides]}
hide
/>
<YAxis
dataKey="planned_hour"
type="category"
orientation={'right'}
style={{ direction: 'ltr', marginTop: '-10px' }}
/>
<Tooltip content={<CustomTooltip />} />
<Legend />
<Bar dataKey="actual_rides" barSize={20} radius={9} xAxisId={1} opacity={30}>
{hourlyData.map((entry, index) => (
<Cell
key={`cell-${index}`}
fill={mapColorByExecution(entry.planned_rides, entry.actual_rides)}
/>
))}
</Bar>
<Bar dataKey="planned_rides" barSize={20} fill="#413ea055" radius={9} xAxisId={0} />
</ComposedChart>
</ResponsiveContainer>
</>
)}
</div>
Expand Down

0 comments on commit f617794

Please sign in to comment.