Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the system doesn't auto-create files when the format already exists #191

Open
niryariv opened this issue Feb 17, 2021 · 6 comments

Comments

@niryariv
Copy link

  1. User uploaded CSV + XLS files: https://kfar-saba.datacity.org.il/dataset/yoatzim
  2. The system auto-created an extra, redundant XLS file:
    Screen Shot 2021-02-17 at 15 24 23

As usual please give me a time estimate for now

@OriHoch
Copy link
Contributor

OriHoch commented Feb 17, 2021

how do you suggest to fix it? how will the automated process detect this case and decide when to skip generation of xls file?

@niryariv
Copy link
Author

I assumed something like "if an xls file exists, do not create xls file".. What am I missing?

@OriHoch
Copy link
Contributor

OriHoch commented Feb 17, 2021

no problem, that's one way to do it, bear in mind there could be many different files in 1 resource

so if there are any .xls or .xslx file in the resource, don't create another one?

@niryariv
Copy link
Author

yes, checking by the filename. Ie, if the following exist:

a.csv
b.csv
a.xls
b1.xls

create b.xls only

@OriHoch
Copy link
Contributor

OriHoch commented Feb 17, 2021

ok, 1-2 hours

@niryariv
Copy link
Author

thanks. moving to to do for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants