Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Prettier v3 & prettier-plugin-apex v2 #857

Open
Jyleuleu opened this issue Oct 28, 2024 · 2 comments
Open

Upgrade to Prettier v3 & prettier-plugin-apex v2 #857

Jyleuleu opened this issue Oct 28, 2024 · 2 comments

Comments

@Jyleuleu
Copy link

Hello,

To resolve Prettier crashes when formatting Apex classes with the latest VSCode version (EINVAL), we have upgraded to Prettier v3.3.3 and prettier-plugin-apex v2.1.5.

Would it be possible to upgrade the versions of Prettier and prettier-plugin-apex used in the quality_check job?"

Thanks

@yamioliva
Copy link
Contributor

Hi @nvuillam,

Just a quick nudge to check if you’ve had a chance to look at issue #857. Jean-Luc posted it a little while back, and we were curious if an upgrade to Prettier v3.3.3 and prettier-plugin-apex v2.1.5 could help with those pesky formatting issues in Apex on the latest VSCode.

No rush at all! Just thought I’d drop a line to keep it on the radar. 😊

Thanks so much!

@nvuillam
Copy link
Member

MegaLinter embeds Salesforce Code Analyzer, which embeds PMD, eslint .... not sure about prettier :/

https://developer.salesforce.com/docs/platform/salesforce-code-analyzer/overview

Anyway, the call to formatters is not blocking when failed ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants