Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Enchanted Clock Reminders #3051

Open
wants to merge 22 commits into
base: beta
Choose a base branch
from

Conversation

DavidArthurCole
Copy link
Contributor

@DavidArthurCole DavidArthurCole commented Dec 12, 2024

Dependencies

What

https://discord.com/channels/997079228510117908/1316578743095005224
Adds optional reminder(s) when enchanted clock boosts become available.

Changelog New Features

  • Added reminders for Enchanted Clock boosts. - Daveed

@hannibal002 hannibal002 added this to the Version 0.29 milestone Dec 13, 2024
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Dec 17, 2024
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Dec 17, 2024
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot added the Detekt Has detekt problem label Dec 17, 2024
Copy link

One or more Detekt Failures were detected:

  • SimpleTimeMark.kt#L14: Class 'SimpleTimeMark' with '20' functions detected. Defined threshold inside classes is set to '20'

@DavidArthurCole
Copy link
Contributor Author

I could've sworn I suppressed that during the merge... whatever, yap away, bot

@github-actions github-actions bot removed the Detekt Has detekt problem label Dec 17, 2024
@DavidArthurCole
Copy link
Contributor Author

Kinda forgot I had developed this, as it doesn't appear to be working atm. The baseline setup for loading the clock stuff should be good, but the reminders might be bugged.

@DavidArthurCole
Copy link
Contributor Author

image

@jani270 jani270 added the Soon This Pull Request will be merged within the next couple of betas label Jan 4, 2025
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont see how the value in storage.clockBoosts gets updated after the first time usage

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 4, 2025
Copy link

github-actions bot commented Jan 4, 2025

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 4, 2025
Copy link

github-actions bot commented Jan 4, 2025

Conflicts have been resolved! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Soon This Pull Request will be merged within the next couple of betas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants