Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protocol original schema string #317

Closed
elia-bracci-hs opened this issue Oct 20, 2023 · 4 comments
Closed

Add protocol original schema string #317

elia-bracci-hs opened this issue Oct 20, 2023 · 4 comments

Comments

@elia-bracci-hs
Copy link
Contributor

elia-bracci-hs commented Oct 20, 2023

I would like to add also another field in Protocol struct. Here the PR.

I called it OriginalString but we can change it. The intent is to save the string of the protocol as is, using its non-canonical form. WDYT?

I need this to generate Protocol hash.

cc: @nrwiersma

@nrwiersma
Copy link
Member

The protocol hash is already generated, and should be generated using the canonical form.

Given that you already have the original protocol string, should you still need a hash, you could make it yourself.

@elia-bracci-hs
Copy link
Contributor Author

Thank you for your feedback. Yes, this is what I'm doing right now. My intent was to see if I'm the only one with this kind of "issue". We can close the issue if you want 👍

@nrwiersma
Copy link
Member

The hash you need is non-spec, from my reading. The hash of the protocol is meant to be used in the protocol wire format, which should be of the canonical.

I dont know what you need the non-canonical hash for, but I prefer to keep this module based around specs.

@elia-bracci-hs
Copy link
Contributor Author

elia-bracci-hs commented Oct 20, 2023

I agree with you 👍 I'll close the issue, thank you 🙏 Hope to help with more contributions 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants