Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build to Gradle 8 #45

Merged
merged 4 commits into from
Oct 23, 2023
Merged

Update build to Gradle 8 #45

merged 4 commits into from
Oct 23, 2023

Conversation

stempler
Copy link
Member

Runs with Java 17

@emanuelaepure10
Copy link
Contributor

I have finally a successful build.
I have an error thought

Error opening Zip file
  C:\Users\EmanuelaEpure\Documents\GitHub\hale-platform-update\hale-platform\build\plugins\org.h2.source_1.3.171.i20221102.jar
  -- or --
  C:\Users\EmanuelaEpure\Documents\GitHub\hale-platform-update\hale-build-support\updatesites\platform\plugins\org.h2.source_1.3.171.i20221102.jar
 -> Invalid CEN header (invalid extra data field size for tag: 0xbfef at 492)

but LGTM.

Copy link
Member

@florianesser florianesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Builds for me also when upgrading the GeoTools dependency.

Note: hale»studio doesn't build for me yet with a platform created from this PR.

@stempler
Copy link
Member Author

Thanks a lot for the feedback. I used the opportunity to also add the CI task previously prepared in another PR and adapt it to the Gradle update.

I have an error thought

These kind of error logs are expected. Ideally they won't happen in the future when all bundles have been created without those Zip file problems.

@stempler stempler merged commit 609f811 into master Oct 23, 2023
1 check failed
@stempler stempler deleted the gradle-8 branch October 23, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants