Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple package produces invalid "Docs" link in header #30

Open
krlmlr opened this issue Jun 25, 2017 · 2 comments
Open

Simple package produces invalid "Docs" link in header #30

krlmlr opened this issue Jun 25, 2017 · 2 comments

Comments

@krlmlr
Copy link

krlmlr commented Jun 25, 2017

https://github.com/krlmlr/tic.packagedocs => https://krlmlr.github.io/tic.packagedocs, I basically just called init_vignettes() without adapting the generated code. See https://travis-ci.org/krlmlr/tic.packagedocs/builds/246795288#L1424 for the build log.

I have also found that it seems necessary to install the package before building the documentation, but I guess this is by design.

@hafen
Copy link
Owner

hafen commented Jun 26, 2017

Thanks for the report. That is indeed not how the docs link should be populated with the initialization. I have made a fix here: https://github.com/hafen/packagedocs/tree/fix-docs-link. I haven't verified yet but will merge after making sure it works.

@EricMarcon
Copy link

After running packagedocs::init_vignettes() , I get in the headers of _docs.Rmd and rd.Rmd
navpills: |

  <li><a href='docs.html'>Docs</a></li>

It should be :

  <li><a href='index.html'>Docs</a></li>

Correcting it solves the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants