Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need to port the existing tree renderer to React? #11

Closed
dhess opened this issue Aug 8, 2021 · 2 comments
Closed

Do we need to port the existing tree renderer to React? #11

dhess opened this issue Aug 8, 2021 · 2 comments

Comments

@dhess
Copy link
Member

dhess commented Aug 8, 2021

Something that's just occurred to me is that I'm not sure whether d3js or other JavaScript drawing APIs will generate accessible trees. Specifically, I'm concerned about screen readers. I suspect we could make our existing tree renderer work with a screen reader since it's just standard DOM elements, so we might want to port it to React and use it as an accessible renderer.

@dhess dhess transferred this issue from another repository Sep 18, 2021
@dhess dhess transferred this issue from another repository Sep 23, 2021
@brprice
Copy link
Contributor

brprice commented Dec 7, 2021

This was done but not polished (needs some css tweaks etc) in https://github.com/hackworthltd/primer-app/tree/brprice/tree-html-fancy (This has not been merged to main) . A simple nested-list outline view was added (and merged to main) in #112 , which should work well with a screen reader.

@brprice brprice closed this as completed Dec 7, 2021
@dhess
Copy link
Member Author

dhess commented Dec 7, 2021

Agreed. If #112 turns out not work well with screen readers, we can revisit this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants