Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service_area_name property to output of /budget/history/bureau/ endpoint #132

Open
jimtyhurst opened this issue Apr 18, 2017 · 0 comments

Comments

@jimtyhurst
Copy link
Contributor

Expected behavior:

Whenever a "code" property appears in API output, the response should also include the corresponding "name" property. The Bureau endpoint response has the service_area_code, so a user expects the response to also have a service_area_name property in the same way that the response has bureau_code and bureau_name properties in the response.

Actual behavior

The Bureau endpoint does not have a service_area_name property.

Background info

The History table has code/name properties for all of the properties, except for "service area". So we need to join the budget_app_budgethistory table to the budget_app_lookupcode table to use the service_area_code in the budget_app_budgethistory table to get the description in the budget_app_lookupcode table.

This is a follow-up to the endpoint developed as a solution to Issue #76.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant