Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pv_vision.transform_crop._cell_crop.detect_vertical_lines needs debugging #16

Open
eccoope opened this issue Feb 16, 2024 · 1 comment

Comments

@eccoope
Copy link

eccoope commented Feb 16, 2024

Was trying to run through tutorials/transform_split.ipynb and noticing a couple of issues.

  1. Easy to fix - when detect_vertical_lines( ) calls split_img( ), an incorrect keyword is used (split instead of n_split) which raises an error
  2. More involved fix - IndexError is raised when detectoutliers( ) is called by detect_vertical_lines( )in line 364. The error is triggered by line 125 in detectoutliers( ). Not sure what is causing this.
@X-Chen97
Copy link
Collaborator

X-Chen97 commented Jun 4, 2024

Thanks for the comments. I have fix the bug and tutorials/transform_split.ipynb can run without error now.

Can you provide more details of your second issue? I cannot repeat what you described.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants