Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atomate v2: issues that require issues #292

Open
3 tasks
computron opened this issue May 30, 2019 · 2 comments
Open
3 tasks

Atomate v2: issues that require issues #292

computron opened this issue May 30, 2019 · 2 comments
Labels
improvement reported issues that considered further improvement to atomate

Comments

@computron
Copy link
Contributor

Here are some issues that may require their own separate issues at some point

  • Hard to know how to write workflows where there are multiple parallel calculations followed by an analysis step. Should the analysis step be part of the workflow itself, or should a builder perform the analysis based on raw calculations in the task database?
  • Can't use atomate in "offline" mode. The VaspCalcDb doesn't support any kind of offline. Not sure if we should even try or not
  • What to do about atomate builders? Keep as-is or use MP builder framework?
@JosephMontoya-TRI
Copy link

  • I think builder > analysis generally, but beware that builders require kind of a different style thinking about how to organize and ensure all of the tasks contain all of the metadata one needs. We've had to work really hard (perhaps too hard) to ensure that builders are agnostic to workflow-level information in emmet, which isn't necessary if you're doing the analysis as part of the workflow, since you can just pass the analysis firework the information it needs.
  • I don't think offline is worth it.
  • I think we should use the MP builder framework, mostly I don't think anyone from MP is going to want to duplicate the effort that went into it and the processes should probably be the same anyway (perhaps with atomate's build being a subset of the larger MP build procedure).

@JosephMontoya-TRI
Copy link

JosephMontoya-TRI commented May 31, 2019

I also want to add a feature I'd like to see realized (I'm doing it here not as a request for someone else to implement, but in the hopes that whatever refactor may come will not preclude it). I think the fact that atomate requires a shared filesystem to pass things like VASP files to be a bit of a burden and very much wish that these files could be passed, synced, etc. through a cloud storage resource.

@itsduowang itsduowang added enhancement improvement reported issues that considered further improvement to atomate and removed enhancement labels Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement reported issues that considered further improvement to atomate
Projects
None yet
Development

No branches or pull requests

3 participants