Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add date_from on item loans #713

Closed
CJGutz opened this issue Jan 31, 2023 · 0 comments · Fixed by #793
Closed

Add date_from on item loans #713

CJGutz opened this issue Jan 31, 2023 · 0 comments · Fixed by #793
Assignees
Labels
enhancement frontend good first issue A task that should be straight forward and easy to get started on.

Comments

@CJGutz
Copy link
Member

CJGutz commented Jan 31, 2023

Is your feature request related to a problem? Please describe.
Users want to be able to plan their loan, but not necessarily start it right away. It should be possible to set when the loan will start from. This is not required so if a user does not set it, it is defaulted to the day, the loan was instantiated.

Describe the solution you'd like
The model ItemLoan tracks when the loan has started, but it is defaulted to timezone.now. This can be kept. Instead should the form be edited to include the loan_from property which is nullable. Check that the max loan time restriction still works.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@CJGutz CJGutz added enhancement frontend good first issue A task that should be straight forward and easy to get started on. labels Jan 31, 2023
@LarsMstangeland LarsMstangeland self-assigned this Jan 31, 2023
@CJGutz CJGutz changed the title Add date from on item loans Add date_from on item loans Jan 31, 2023
@erlendska erlendska linked a pull request Feb 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement frontend good first issue A task that should be straight forward and easy to get started on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants