From 48059eb8a6cca522f75ce33bce43f542681a1d6f Mon Sep 17 00:00:00 2001 From: ZeroWave022 <36341766+ZeroWave022@users.noreply.github.com> Date: Sat, 28 Sep 2024 13:49:45 +0200 Subject: [PATCH 1/3] build: Restructure lhci config, ignore some rules for storage pages --- lighthouserc.yml | 54 +++++++++++++++++++++++++++--------------------- 1 file changed, 30 insertions(+), 24 deletions(-) diff --git a/lighthouserc.yml b/lighthouserc.yml index 8c8adb7..6e87b0f 100644 --- a/lighthouserc.yml +++ b/lighthouserc.yml @@ -11,27 +11,33 @@ ci: target: 'temporary-public-storage' assert: preset: 'lighthouse:recommended' - assertions: - first-contentful-paint: - - error - - maxNumericValue: 2000 - aggregationMethod: optimistic - interactive: - - error - - maxNumericValue: 5000 - aggregationMethod: optimistic - bf-cache: 'off' - csp-xss: 'off' - identical-links-same-purpose: 'off' - total-byte-weight: 'off' - color-contrast: 'off' - heading-order: 'off' - mainthread-work-breakdown: 'off' - bootup-time: 'off' - largest-contentful-paint: 'off' - dom-size: 'off' - render-blocking-resources: 'off' - server-response-time: 'off' - uses-responsive-images: 'off' - maskable-icon: 'off' - installable-manifest: 'off' + assertMatrix: + - matchingUrlPattern: ".*" + assertions: + first-contentful-paint: + - error + - maxNumericValue: 2000 + aggregationMethod: optimistic + interactive: + - error + - maxNumericValue: 5000 + aggregationMethod: optimistic + bf-cache: 'off' + csp-xss: 'off' + identical-links-same-purpose: 'off' + total-byte-weight: 'off' + color-contrast: 'off' + heading-order: 'off' + mainthread-work-breakdown: 'off' + bootup-time: 'off' + largest-contentful-paint: 'off' + dom-size: 'off' + render-blocking-resources: 'off' + server-response-time: 'off' + uses-responsive-images: 'off' + maskable-icon: 'off' + installable-manifest: 'off' + - matchingUrlPattern: "http://[^/]+/storage.*" + assertions: + unused-javascript: 'off' + cumulative-layout-shift: 'off' From b22b7196395b2385e1c7656aa6356e3e5b334c7a Mon Sep 17 00:00:00 2001 From: ZeroWave022 <36341766+ZeroWave022@users.noreply.github.com> Date: Sat, 28 Sep 2024 13:56:00 +0200 Subject: [PATCH 2/3] fix: lhci config --- lighthouserc.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lighthouserc.yml b/lighthouserc.yml index 6e87b0f..263d46d 100644 --- a/lighthouserc.yml +++ b/lighthouserc.yml @@ -10,9 +10,9 @@ ci: upload: target: 'temporary-public-storage' assert: - preset: 'lighthouse:recommended' assertMatrix: - matchingUrlPattern: ".*" + preset: 'lighthouse:recommended' assertions: first-contentful-paint: - error @@ -38,6 +38,7 @@ ci: maskable-icon: 'off' installable-manifest: 'off' - matchingUrlPattern: "http://[^/]+/storage.*" + preset: 'lighthouse:recommended' assertions: unused-javascript: 'off' cumulative-layout-shift: 'off' From e21d8215f9c4664a1a72f32842307cb4bf4d90ed Mon Sep 17 00:00:00 2001 From: ZeroWave022 <36341766+ZeroWave022@users.noreply.github.com> Date: Sat, 28 Sep 2024 14:02:47 +0200 Subject: [PATCH 3/3] build: Ignore max potential fid for storage pages --- lighthouserc.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/lighthouserc.yml b/lighthouserc.yml index 263d46d..8916d70 100644 --- a/lighthouserc.yml +++ b/lighthouserc.yml @@ -42,3 +42,4 @@ ci: assertions: unused-javascript: 'off' cumulative-layout-shift: 'off' + max-potential-fid: 'off'