Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid rendering two cameras 💀 #908

Closed
4 tasks
toberge opened this issue Dec 23, 2024 · 1 comment · Fixed by #909
Closed
4 tasks

Avoid rendering two cameras 💀 #908

toberge opened this issue Dec 23, 2024 · 1 comment · Fixed by #909
Assignees
Labels
bug Something isn't working

Comments

@toberge
Copy link
Contributor

toberge commented Dec 23, 2024

So what we need to do is:

  • Disable player camera when viewing panning camera
  • Disable panning camera when:
    • joining game with just one player
    • in splitscreen but noone has died yet
  • at start of round the panning camera should be enabled; disable it when player is set up!

which means

  • by default enabled
  • disable panning cam when any player has their setplayerinput method called
  • enable panning cam when player has died basically (could be more granular here)

Should result in a whopping 100% performance increase.

Might resove #804 actually.

@toberge toberge added the bug Something isn't working label Dec 23, 2024
@toberge toberge self-assigned this Dec 23, 2024
@Fueredoriku
Copy link
Contributor

Casual 100% perfomance increase lmao

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done 🎉
Development

Successfully merging a pull request may close this issue.

2 participants