Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brick barrel #894

Merged
merged 6 commits into from
Dec 27, 2024
Merged

Brick barrel #894

merged 6 commits into from
Dec 27, 2024

Conversation

toberge
Copy link
Contributor

@toberge toberge commented Dec 20, 2024 •
edited
Loading

  • Make it possible to pass rotation to mesh projectiles
    • doesn't function properly at the moment, but works well enough for erratic brick movement 😎
  • Refactor VFXPositionFormatter to be a regular class and not a MonoBehaviour
  • Implement velocity inheritance
  • Implement velocity-by-damage
  • Balance damage graph
  • Make damage scale in explosion as well
  • Perhaps do explosion dmg as its own stat?
  • Model a brick
  • remember to make the brick red
  • Create brick explosion
    • Brick splinters
    • White cloud stuff
    • Outline?
  • Model the barrel
    • Speedometer
    • Brick output (rectangular thingy)
    • ????
  • Animate pistons
  • Animate bricks???
  • Write speedometer shader
  • Prettify speedometer
  • Make this work over network :/
  • Make AIs able to use it??? (determine if still or walking at least)

Closes #877

velocity thresholds:

  • 0: still
  • 4: crouch
  • 10: walk
  • 11/12: leap
  • 15: first bunnyleap
  • 17: second bunnyleap
  • 22+: falling velocity
  • 25: top speed

image

@toberge toberge force-pushed the feature/brick-barrel branch 3 times, most recently from 11687f2 to 1218d9b Compare December 23, 2024 15:39
@toberge toberge changed the title brick barrel Brick barrel Dec 23, 2024
@toberge toberge force-pushed the feature/brick-barrel branch 4 times, most recently from 73e87dd to ef37b94 Compare December 25, 2024 19:11
@toberge
Add rotation support to mesh projectiles
2b752a0 
Had to turn VFXPositionFormatter into a regular class (as it should have
been) in order to reasonably support multiple buffers per VFX.
@toberge toberge force-pushed the feature/brick-barrel branch 2 times, most recently from 2434598 to 568e1af Compare December 26, 2024 16:49
@toberge toberge force-pushed the feature/brick-barrel branch 4 times, most recently from 86adb02 to dcbde4f Compare December 26, 2024 19:42
@toberge toberge marked this pull request as ready for review December 26, 2024 19:46
@toberge toberge requested a review from Fueredoriku December 26, 2024 19:46
@toberge toberge force-pushed the feature/brick-barrel branch 2 times, most recently from 40dca80 to f0d62b1 Compare December 26, 2024 19:59
Fueredoriku
Fueredoriku approved these changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@Fueredoriku Fueredoriku left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very fun augment! 👍

  • Rendering layer mask of the mesh renderer should be foreground objects instead of light layer default to avoid decals projecting onto the augment
  • The speedometer material should be unlit so players always can see the values clearly

Also make double sure that all VFXPosition buffers are released, it seems they are from what I can tell, but I'm scared of the potential memory leaks lol

I'll leave an approve you can use after the you fix the material/render mask stuff 😁👍

@toberge toberge force-pushed the feature/brick-barrel branch from f0d62b1 to 2f00335 Compare December 27, 2024 11:56
@toberge toberge merged commit 9efae50 into dev Dec 27, 2024
@toberge toberge deleted the feature/brick-barrel branch December 27, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fueredoriku Fueredoriku Fueredoriku approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Prosjekt-Spill-H22 board
Status: Done 🎉
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Brick barrel
2 participants
@toberge @Fueredoriku