Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Music track fading ignores music volume settings #241

Closed
Fueredoriku opened this issue Oct 12, 2023 · 0 comments · Fixed by #250
Closed

Music track fading ignores music volume settings #241

Fueredoriku opened this issue Oct 12, 2023 · 0 comments · Fixed by #250
Assignees
@Fueredoriku
Labels
bug Something isn't working

Comments

@Fueredoriku
Copy link
Contributor

When music is turned down or even off in the settings, the fading effect will momentarily turn the music it's fading from to 1 in volume
@Fueredoriku Fueredoriku added the bug Something isn't working label Oct 12, 2023
@ghost ghost moved this to Ideas in Prosjekt-Spill-H22 board Oct 12, 2023
Fueredoriku added a commit that referenced this issue Oct 18, 2023
@Fueredoriku
Fix music fade, Fix volume levels, Add extra auctioneer talking
2072185 
- Fix fading issue #241
- Tweak AudioMixer to have similar volume levels for all audio
- Add all audiosources to audioMixer
- Made the auctioneer more talkative
Fueredoriku added a commit that referenced this issue Oct 18, 2023
@Fueredoriku
Fix music fade, Fix volume levels, Add extra auctioneer talking
d1c37fc 
- Fix fading issue #241
- Tweak AudioMixer to have similar volume levels for all audio
- Add all audiosources to audioMixer
- Made the auctioneer more talkative
@Fueredoriku Fueredoriku mentioned this issue Oct 18, 2023
Merged
@Fueredoriku Fueredoriku linked a pull request Oct 18, 2023 that will close this issue
Fix music fade, Fix volume levels, Add extra auctioneer talking #250
Merged
@Fueredoriku Fueredoriku self-assigned this Oct 19, 2023
@github-project-automation github-project-automation bot moved this from Ideas to Done 🎉 in Prosjekt-Spill-H22 board Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Fueredoriku Fueredoriku

Labels
bug Something isn't working
Projects
Prosjekt-Spill-H22 board
Status: Done 🎉
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix music fade, Fix volume levels, Add extra auctioneer talking hackerspace-ntnu/Red-Planet-Rampage
1 participant
@Fueredoriku