Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minor fixes to GAM, GLM, ModelSelection #16433

Open
wendycwong opened this issue Oct 23, 2024 · 0 comments
Open

Add minor fixes to GAM, GLM, ModelSelection #16433

wendycwong opened this issue Oct 23, 2024 · 0 comments
Assignees
@wendycwong
Labels
bug
Milestone
3.46.0.7

Comments

@wendycwong
Copy link
Contributor

wendycwong commented Oct 23, 2024 •
edited
Loading

There are a bunch of changes I noticed while working on HGLM. I am putting them all here for simplicity:

GAM.java:
image

GLM.java
image

image

image

gen_gam.py, remove _additional_used_columns from it.

image
@wendycwong wendycwong added the bug label Oct 23, 2024
@wendycwong wendycwong self-assigned this Oct 23, 2024
@wendycwong wendycwong changed the title Add minor changes to GAM, GLM, Add minor fixes to GAM, GLM, ModelSelection Oct 23, 2024
wendycwong pushed a commit that referenced this issue Oct 23, 2024
GH-16433: add changes to various algos to fix minor errors.
6bf4950
@wendycwong wendycwong added this to the 3.46.0.7 milestone Oct 23, 2024
@wendycwong wendycwong mentioned this issue Oct 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wendycwong wendycwong

Labels
bug
Projects
None yet
Milestone
3.46.0.7
Development

No branches or pull requests
1 participant
@wendycwong