Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend code review FileUploadController #18

Open
TomasKulhanek opened this issue Feb 2, 2018 · 3 comments
Open

backend code review FileUploadController #18

TomasKulhanek opened this issue Feb 2, 2018 · 3 comments
Assignees

Comments

@TomasKulhanek
Copy link
Member

TomasKulhanek commented Feb 2, 2018

The class org.cirmmp.spring.controller.FileUploadController is good to post binary files via HTTP - however, I'd be afraid, if it scales for big files. Therefore I'd recommend to remove this controller completely.
The functionality to handle single files is already on WEBDAV interface which is provided by the apache mod_dav module, it can handle GET,POST,PUT,DELETE as well as PROPFIND (aka directory listing) on files on the server.

@TomasKulhanek TomasKulhanek added this to the D6.2 Repository Instance milestone Feb 2, 2018
@TomasKulhanek TomasKulhanek changed the title code review FileUploadController backend code review FileUploadController Feb 2, 2018
@andreagia
Copy link
Collaborator

We can remove FileUploadController and for me is ok to use webdav on apache controller to manage files on the server. How do you manage the files (on the server ) -> FileList class identity ?

@TomasKulhanek
Copy link
Member Author

No FileList class - files belongs to dataset managed by backend api.

@TomasKulhanek TomasKulhanek reopened this Feb 16, 2018
@TomasKulhanek TomasKulhanek removed their assignment Feb 16, 2018
@TomasKulhanek
Copy link
Member Author

Can you do that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants