New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading non context-aware native modules in the renderer process is deprecated #239

Open

2 of 3 tasks

pixtron opened this issue Feb 17, 2020 · 1 comment

Open

2 of 3 tasks

Loading non context-aware native modules in the renderer process is deprecated #239

pixtron opened this issue Feb 17, 2020 · 1 comment

Labels

change

Member

pixtron commented Feb 17, 2020 •

edited by raffis

Loading

Describe the change

Loading non context-aware native modules in the renderer process is deprecated

Current situation

We get the deprecation message everytime a sync starts. Most likely it is the nsfw module which is not context aware.

Should

We should check all native modules used, if they are context aware.

Additional context

(node:60582) Electron: Loading non context-aware native modules in the renderer process is deprecated and will stop working at some point in the future, please see https://github.com/electron/electron/issues/18397 for more information

Modules we should check

keytar (is already context aware)
@gyselroth/node-advanced-desktop (is a NAPI module)
nsfw

The text was updated successfully, but these errors were encountered:

pixtron added the change label

pixtron added this to the 1.3.x milestone

Member Author

pixtron commented Mar 2, 2020

Created an issue for nsfw: Axosoft/nsfw/issues/100

pixtron removed this from the 1.3.x milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment