Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: state variables/concepts lose their description in template_model_to_petrinet_json #389

Closed
liunelson opened this issue Oct 23, 2024 · 1 comment

Comments

@liunelson
Copy link

template_model_to_petrinet_json is lossy when it comes to the description of the state variable concepts.

def template_model_to_petrinet_json(tm: TemplateModel):

The PetriNet AMR JSON schema supports state variable descriptions; so, concept description should probably be preserved in the JSON.

Example:

@nanglo123
Copy link
Contributor

nanglo123 commented Oct 23, 2024

I believe the issue has been fixed.

Here is an example of a petrinet amr that was created from loading in the template model json you linked (the first file) and exporting it as a petrinet amr. As you can see concept descriptions are now propogated.

https://raw.githubusercontent.com/nanglo123/mira/42f9725fc23b5f8d0d64b46850a1af5b57ccfd01/mira/modeling/amr/propogated_concept_description_petrinet.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants