Segment tags #4468
Merged
Segment tags #4468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spxiwh
requested changes
Aug 29, 2023
There was a problem hiding this comment.
Thanks Max. This largely looks good, but some minor requests made here.
Also as a style thing, when a function uses tags as a key-word argument, I prefer it if that function is called with tags=tags, rather than just tags. This avoids issues if we change the function in the future.
Also one line that maybe could be wrapped to 80 characters pointed out by CodeClimate.
spxiwh
reviewed
Aug 29, 2023
|
@spxiwh this should be good to go now |
spxiwh
approved these changes
Aug 29, 2023
|
@spxiwh I added one more commit so that the segments workflow can parse a dq flag provided in the |
GarethCabournDavies
pushed a commit
to GarethCabournDavies/pycbc
that referenced
this pull request
Oct 11, 2023
* Added support for dq tags * Small fix * Addressed some of Ian's comments * Fixed indent mistake * Added description of tags argument to docstring * Small fix to tags * Don't use tags with veto-definer * Don't require dq segments to be set for each ifo separately * Fixed over-indent
PRAVEEN-mnl
pushed a commit
to PRAVEEN-mnl/pycbc
that referenced
this pull request
Nov 3, 2023
* Added support for dq tags * Small fix * Addressed some of Ian's comments * Fixed indent mistake * Added description of tags argument to docstring * Small fix to tags * Don't use tags with veto-definer * Don't require dq segments to be set for each ifo separately * Fixed over-indent
bhooshan-gadre
pushed a commit
to bhooshan-gadre/pycbc
that referenced
this pull request
Mar 4, 2024
* Added support for dq tags * Small fix * Addressed some of Ian's comments * Fixed indent mistake * Added description of tags argument to docstring * Small fix to tags * Don't use tags with veto-definer * Don't require dq segments to be set for each ifo separately * Fixed over-indent
acorreia61201
pushed a commit
to acorreia61201/pycbc
that referenced
this pull request
Apr 4, 2024
* Added support for dq tags * Small fix * Addressed some of Ian's comments * Fixed indent mistake * Added description of tags argument to docstring * Small fix to tags * Don't use tags with veto-definer * Don't require dq segments to be set for each ifo separately * Fixed over-indent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for segments to be read from different locations in one search by using config tags