Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue of std::shared_ptr to queue of std::unique_ptr? #142

Open
gvansickle opened this issue Feb 3, 2024 · 0 comments
Open

Queue of std::shared_ptr to queue of std::unique_ptr? #142

gvansickle opened this issue Feb 3, 2024 · 0 comments

Comments

@gvansickle
Copy link
Owner

Globber/DirTree use a "sync_queue<std::shared_ptr>& m_out_queue;" to move FileIDs from the globbing threads to the scanning threads. It's not clear to me atm why these couldn't be "sync_queue<std::unique_ptr...", though there might be a reason I'm not thinking of. Changing to unique_ptr, if possible, would eliminate ref counting overhead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant